kubernetes-sigs / network-policy-api

This repo addresses further work involving Kubernetes network security beyond the initial NetworkPolicy resource
Apache License 2.0
51 stars 29 forks source link

Print status as part of the printer columns #115

Closed tssurya closed 10 months ago

tssurya commented 1 year ago

This commit adds support for printing the status of ANP and BANP when doing kubectl get so that implementations can let users know the status of these resources - note that the status field is not standardtized and is upto the plugins to implement them according to their logic.

Sample output:

$ oc get anp pass-example 
NAME           PRIORITY   AGE   CONDITION                 STATUS   REASON
pass-example   10         13m   AdminNetworkPolicyReady   True     SetupSucceeded
k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tssurya Once this PR has been reviewed and has the lgtm label, please assign dyanngg for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes-sigs/network-policy-api/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
netlify[bot] commented 1 year ago

Deploy Preview for kubernetes-sigs-network-policy-api ready!

Name Link
Latest commit 8c58c92752eedac7d807bcbcb7ed3bb43cb8740a
Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-network-policy-api/deploys/647cb9457e85bc000796a135
Deploy Preview https://deploy-preview-115--kubernetes-sigs-network-policy-api.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

astoycos commented 10 months ago

I forget where we landed with this @tssurya Can we close or do we need to make a new issue /and or keep it open?

astoycos commented 10 months ago

Closing for now please re-open if needed @tssurya