kubernetes-sigs / network-policy-api

This repo addresses further work involving Kubernetes network security beyond the initial NetworkPolicy resource
Apache License 2.0
51 stars 29 forks source link

Create NPEP-122 for Tenancy API update. #123

Closed npinaeva closed 8 months ago

npinaeva commented 1 year ago

Change Tenancy implementation from SameLabels/NotSameLabels ANP peers to a separate object that will define Tenancy considering subject and peers are related.

Tracking issue https://github.com/kubernetes-sigs/network-policy-api/issues/122

netlify[bot] commented 1 year ago

Deploy Preview for kubernetes-sigs-network-policy-api ready!

Name Link
Latest commit 310e46a4e64fac313d5a09b331dd5ddbb9f6dbc4
Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-network-policy-api/deploys/654959808c3764000881fb9c
Deploy Preview https://deploy-preview-123--kubernetes-sigs-network-policy-api.netlify.app/npeps/npep-122
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

k8s-ci-robot commented 1 year ago

Hi @npinaeva. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
npinaeva commented 1 year ago

/ok-to-test

npinaeva commented 11 months ago

As discussed in the upstream meeting, this version is focused on user stories now, which led me to writing down even more user stories, and also covering existing API fields that I couldn't figure out user stories for. Since the main problem of the existing API is covering much more configs that we actually have user stories for, we probably shouldn't include fields that we don't have user stories for in the next Tenancy API.

shaneutt commented 10 months ago

/cc

k8s-ci-robot commented 9 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: astoycos, npinaeva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/network-policy-api/blob/main/OWNERS)~~ [astoycos] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
danwinship commented 8 months ago

/lgtm

danwinship commented 8 months ago

/hold cancel

astoycos commented 8 months ago

/lgtm

🍾