Closed tssurya closed 8 months ago
Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all
Name | Link |
---|---|
Latest commit | 7e9c9b451a66a606a098071a68e502102aa0cb63 |
Latest deploy log | https://app.netlify.com/sites/kubernetes-sigs-network-policy-api/deploys/653165f36e7380000864efc3 |
Deploy Preview | https://deploy-preview-142--kubernetes-sigs-network-policy-api.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
/area conformance
@Dyanngg : PTAL! I am super interested to see if you can pull these changes in, bring up an antrea cluster, point the KUBECONFIG to it and then run:
go test -v ./conformance -run TestConformanceProfiles -args --conformance-profiles=AdminNetworkPolicy,BaselineAdminNetworkPolicy --organization=ovn-org -project=ovn-kubernetes -url="https://github.com/ovn-org/ovn-kubernetes" -version=0.1.1 -contact=@tssurya -additional-info="blah"
something like that how does your test report look?
@Dyanngg : PTAL! I am super interested to see if you can pull these changes in, bring up an antrea cluster, point the KUBECONFIG to it and then run: go test -v ./conformance -run TestConformanceProfiles -args --conformance-profiles=AdminNetworkPolicy,BaselineAdminNetworkPolicy --organization=ovn-org -project=ovn-kubernetes -url="https://github.com/ovn-org/ovn-kubernetes" -version=0.1.1 -contact=@tssurya -additional-info="blah" something like that how does your test report look?
Pretty much the same results:
=== NAME TestConformanceProfiles
conformance_profile_test.go:142: Conformance report:
apiVersion: policy.networking.k8s.io/v1alpha1
date: "2023-10-19T13:52:40-07:00"
implementation:
additionalInformation: blah
contact:
- '@dyanngg'
organization: antrea.io
project: antrea
url: https://github.com/antrea-io/antrea
version: v1.13
kind: ConformanceReport
networkPolicyV2APIVersion: v0.1.2
profiles:
- core:
result: success
statistics:
Failed: 0
Passed: 7
Skipped: 0
summary: ""
name: AdminNetworkPolicy
- core:
result: success
statistics:
Failed: 0
Passed: 7
Skipped: 0
summary: ""
name: BaselineAdminNetworkPolicy
Although tbh I feel like the addtionalInfo section is a bit unclear/unstructured at this point. We might want to take a look around and see if there's a standardized way where CI info can be passed, i.e. maybe a struct that supports mainstream CIs like github action/jenkins/argo etc.
Although tbh I feel like the addtionalInfo section is a bit unclear/unstructured at this point. We might want to take a look around and see if there's a standardized way where CI info can be passed, i.e. maybe a struct that supports mainstream CIs like github action/jenkins/argo etc.
I understand and agree fully. Let me open an issue to track this for us to do better moving forward. String is too loose ended.
Opened https://github.com/kubernetes-sigs/network-policy-api/issues/160 to fix additional info field
/approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: astoycos, Dyanngg, tssurya
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/lgtm
Sample Output for Conformance Reports:
How to run tests in profiles mode?
Related to #137