kubernetes-sigs / network-policy-api

This repo addresses further work involving Kubernetes network security beyond the initial NetworkPolicy resource
Apache License 2.0
50 stars 28 forks source link

Add blog post for getting started with ANP #146

Closed Dyanngg closed 5 months ago

Dyanngg commented 9 months ago

Adding the first blog post for the network-policy-api website, covering basics of AdminNetworkPolicy API usage and interoperation with NetworkPolicy

netlify[bot] commented 9 months ago

Deploy Preview for kubernetes-sigs-network-policy-api ready!

Name Link
Latest commit 6f17d5fe64921b18d307a53a7b425562402a54ca
Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-network-policy-api/deploys/65c11b3344398e0008e9c363
Deploy Preview https://deploy-preview-146--kubernetes-sigs-network-policy-api.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Dyanngg commented 9 months ago

/cc @rahulkjoshi @npinaeva

k8s-ci-robot commented 9 months ago

@Dyanngg: GitHub didn't allow me to request PR reviews from the following users: rahulkjoshi.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to [this](https://github.com/kubernetes-sigs/network-policy-api/pull/146#issuecomment-1741372262): >/cc @rahulkjoshi @npinaeva Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
astoycos commented 6 months ago

@Dyanngg Are you ready for another pass here?

Dyanngg commented 5 months ago

@Dyanngg Are you ready for another pass here?

Yep I think the vast majority of your first round comments are addressed

astoycos commented 5 months ago

This looks great @Dyanngg!! Please just Add it to the blog https://network-policy-api.sigs.k8s.io/blog/ by moving to https://github.com/kubernetes-sigs/network-policy-api/tree/main/site-src/blog/posts updating the index etc

Otherwise it should be GTG

Dyanngg commented 5 months ago

@astoycos Can you check if you have any other comments that need to be addressed? Otherwise let's get our first blog on to the website :P

astoycos commented 5 months ago

@Dyanngg Content looks good but the blog still isn't rendering correctly I don't think :)

https://deploy-preview-146--kubernetes-sigs-network-policy-api.netlify.app/blog/

Dyanngg commented 5 months ago

@Dyanngg Content looks good but the blog still isn't rendering correctly I don't think :)

https://deploy-preview-146--kubernetes-sigs-network-policy-api.netlify.app/blog/

Thanks for checking Andrew!! Now it renders correctly but seems the entire blog content is on the index page. Maybe it's because there's only one blog as of now?

astoycos commented 5 months ago

I fixed it @Dyanngg :) 🥳

/lgtm /approve

k8s-ci-robot commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: astoycos, Dyanngg, huntergregory

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/network-policy-api/blob/main/OWNERS)~~ [Dyanngg,astoycos] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment