Closed Dyanngg closed 5 months ago
Name | Link |
---|---|
Latest commit | 6f17d5fe64921b18d307a53a7b425562402a54ca |
Latest deploy log | https://app.netlify.com/sites/kubernetes-sigs-network-policy-api/deploys/65c11b3344398e0008e9c363 |
Deploy Preview | https://deploy-preview-146--kubernetes-sigs-network-policy-api.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
/cc @rahulkjoshi @npinaeva
@Dyanngg: GitHub didn't allow me to request PR reviews from the following users: rahulkjoshi.
Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.
@Dyanngg Are you ready for another pass here?
@Dyanngg Are you ready for another pass here?
Yep I think the vast majority of your first round comments are addressed
This looks great @Dyanngg!! Please just Add it to the blog https://network-policy-api.sigs.k8s.io/blog/ by moving to https://github.com/kubernetes-sigs/network-policy-api/tree/main/site-src/blog/posts updating the index etc
Otherwise it should be GTG
@astoycos Can you check if you have any other comments that need to be addressed? Otherwise let's get our first blog on to the website :P
@Dyanngg Content looks good but the blog still isn't rendering correctly I don't think :)
https://deploy-preview-146--kubernetes-sigs-network-policy-api.netlify.app/blog/
@Dyanngg Content looks good but the blog still isn't rendering correctly I don't think :)
https://deploy-preview-146--kubernetes-sigs-network-policy-api.netlify.app/blog/
Thanks for checking Andrew!! Now it renders correctly but seems the entire blog content is on the index page. Maybe it's because there's only one blog as of now?
I fixed it @Dyanngg :) 🥳
/lgtm /approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: astoycos, Dyanngg, huntergregory
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Adding the first blog post for the network-policy-api website, covering basics of AdminNetworkPolicy API usage and interoperation with NetworkPolicy