add shellcheck verification step to makefile

gabrielggg commented 7 months ago

Hi.

This is to resolve https://github.com/kubernetes-sigs/network-policy-api/issues/94

This install.sh file is a script i created to simplify the instalation of shellcheck, it is a fork from this script https://github.com/golangci/golangci-lint/blob/master/install.sh which is used on the verify-golint.sh script from this repo. If you want i can upload that script also here, now it is hosted on my personal repo.

I took the same approach you used on https://github.com/kubernetes-sigs/network-policy-api/issues/37 creating a verify-shellcheck.sh script so that it gets automatically included on the ci pipeline because of the hack/verify-all.sh script wildcard usage.

p.s. This is my first PR to a kubernetes project, so i hope everything goes well.

linux-foundation-easycla[bot] commented 7 months ago

The committers listed above are authorized under a signed CLA.

:white_check_mark: login: gabrielggg / name: Gabriel Gómez de la Torre (fac725f03992a4d31181cf9e7328bb3b370ef66a, 934bafa7f5135f7167bb8de5c7011e36df871b54, 534d9233d3126a3bbd078ae2622ad9682dc9c443)

netlify[bot] commented 7 months ago

Deploy Preview for kubernetes-sigs-network-policy-api ready!

Name	Link
Latest commit	534d9233d3126a3bbd078ae2622ad9682dc9c443
Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-network-policy-api/deploys/65cd669e665f8c000888a1bd
Deploy Preview	https://deploy-preview-181--kubernetes-sigs-network-policy-api.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

k8s-ci-robot commented 7 months ago

Welcome @gabrielggg!

It looks like this is your first PR to kubernetes-sigs/network-policy-api 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/network-policy-api has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot commented 7 months ago

Hi @gabrielggg. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

astoycos commented 7 months ago

/ok-to-test

Thanks for your first PR!! @gabrielggg I'll review today

gabrielggg commented 7 months ago

hi @astoycos , i squashed the commits and then proceeded to fix all the scripts so that the test is passing now, please check it out!

astoycos commented 6 months ago

Looks pretty much there!! Can you rebase please?

gabrielggg commented 5 months ago

Done with the rebase @astoycos

astoycos commented 5 months ago

/retest