kubernetes-sigs / network-policy-api

This repo addresses further work involving Kubernetes network security beyond the initial NetworkPolicy resource
Apache License 2.0
50 stars 28 forks source link

Fix tests to reflect newAPI changes #214

Closed tssurya closed 3 months ago

tssurya commented 3 months ago

We fixed the peer API to be symmetric to the subject API via https://github.com/kubernetes-sigs/network-policy-api/pull/196

Let's change this to also reflect on the test cases.

So change:

- namespaces:
        namespaceSelector:
          matchLabels:

to

- namespaces:
          matchLabels:

in peers everywhere

netlify[bot] commented 3 months ago

Deploy Preview for kubernetes-sigs-network-policy-api ready!

Name Link
Latest commit 815e22ce627330bba5174aa9c769e03c39aec571
Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-network-policy-api/deploys/66057df41028c6000859043f
Deploy Preview https://deploy-preview-214--kubernetes-sigs-network-policy-api.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

tssurya commented 3 months ago

I am testing this on ovnk once I make the related changes there. hold.

tssurya commented 3 months ago

ran this against: https://github.com/ovn-org/ovn-kubernetes/pull/4245 which consumes the new syntax for namespace peers and its working.

PASS
ok      sigs.k8s.io/network-policy-api/conformance      376.320s

looks fine; let's merge

astoycos commented 3 months ago

/lgtm /approve

Thanks @tssurya!!!

k8s-ci-robot commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: astoycos, tssurya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/network-policy-api/blob/main/OWNERS)~~ [astoycos] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment