kubernetes-sigs / network-policy-api

This repo addresses further work involving Kubernetes network security beyond the initial NetworkPolicy resource
Apache License 2.0
54 stars 29 forks source link

Leverage kubebuilder annotations generator #77

Closed tssurya closed 1 year ago

tssurya commented 1 year ago

This PR updates the controller-tools version to 0.11.1. That will give us the support for annotating CRDs with api-approved annotation using kubebuilder. See https://github.com/kubernetes-sigs/controller-tools/issues/751.

This is a much cleaner way of generating the right annotations. Hence we don't need to do the extra patches and can remove some redundant files.

This makes lifes easier for CNI plugin implementations as they try to install the CRDs since vendoring the repo will not bring in the config folder and all plugins will need to generate their own set of CRDs. Hence its better to annotate this using kubebuilder to avoid expecting plugins to patch the annotation manually

Solves 2 & 3 points in https://github.com/kubernetes-sigs/network-policy-api/issues/76

/assign @astoycos This is another thing I ran into as I was vendoring stuff into OVNK. PTAL.

netlify[bot] commented 1 year ago

Deploy Preview for kubernetes-sigs-network-policy-api ready!

Name Link
Latest commit 1f9de241bf1e6f77db875150664ddfcceeab7ffd
Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-network-policy-api/deploys/64077679dfd6270008275830
Deploy Preview https://deploy-preview-77--kubernetes-sigs-network-policy-api.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rikatz, tssurya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/network-policy-api/blob/master/OWNERS)~~ [rikatz] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
tssurya commented 1 year ago

/hold cancel

tssurya commented 1 year ago

/assign @astoycos or @Dyanngg

k8s-ci-robot commented 1 year ago

@tssurya: GitHub didn't allow me to assign the following users: or.

Note that only kubernetes-sigs members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see the contributor guide

In response to [this](https://github.com/kubernetes-sigs/network-policy-api/pull/77#issuecomment-1463804738): >/assign @astoycos or @Dyanngg Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
astoycos commented 1 year ago

/lgtm

astoycos commented 1 year ago

Thanks!