Add a Script linter to our CI workflow

[astoycos]

We're maintaining a ton of scripts here, it'd be nice to have a shell script specific linter like https://www.shellcheck.net/ or something to make sure we don't miss silly things :)

[astoycos]

/good-first-issue

[k8s-ci-robot]

@astoycos: This request has been marked as suitable for new contributors.

Guidelines

Please ensure that the issue body includes answers to the following questions:

• Why are we solving this issue?
• To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
• Does this issue have zero to low barrier of entry?
• How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-good-first-issue command.

In response to [this](https://github.com/kubernetes-sigs/network-policy-api/issues/94): >/good-first-issue Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

[astoycos]

/help-wanted

[v1ku]

/assign

[v1ku]

Hello @astoycos ,

I'm working on integrating ShellCheck into the project as requested in this issue. Before proceeding, I would like to clarify a few points about the CI/CD pipeline.

Is there an existing CI/CD pipeline for this project that I may have missed? If yes, could you please point me to the relevant configuration files?
If there isn't a CI/CD pipeline set up, are developers expected to run the ShellCheck script manually before pushing their changes to the repository?

[astoycos]

Hi @v1ku, thanks for taking this!!

There is an existing ci/cd pipeline setup managed with prow, let me point you to a PR that should help guide you here.

I think first thing is adding a make target to our local setup to do so and then actually adding a new step to our test-infra setup.

https://github.com/kubernetes-sigs/network-policy-api/issues/37 should help answer any questions.

Meanwhile feel free to ping me here or on slack for more help.

[astoycos]

@v1ku Will you have time to tackle this in the near future? If not please unassign and open up for other contributors 👍

[gabrielggg]

/assign