kubernetes-sigs / nfs-ganesha-server-and-external-provisioner

NFS Ganesha Server and Volume Provisioner.
Apache License 2.0
427 stars 144 forks source link

Authorize RBAC to use `scc/privileged` #112

Closed jglick closed 1 year ago

jglick commented 1 year ago

Otherwise OpenShift refuses to create the NFS server pod for security reasons.

Not tested directly, but it works to use the published chart after

kubectl create clusterrolebinding scc-nfs --clusterrole system:openshift:scc:privileged --serviceaccount my-namespace:the-rbac-sa-name

where the standard role is predefined

apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRole
metadata:
  name: system:openshift:scc:privileged
  ownerReferences:
  - apiVersion: config.openshift.io/v1
    kind: ClusterVersion
    name: version
    uid: …
rules:
- apiGroups:
  - security.openshift.io
  resourceNames:
  - privileged
  resources:
  - securitycontextconstraints
  verbs:
  - use
k8s-ci-robot commented 1 year ago

Welcome @jglick!

It looks like this is your first PR to kubernetes-sigs/nfs-ganesha-server-and-external-provisioner 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/nfs-ganesha-server-and-external-provisioner has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

kvaps commented 1 year ago

/lgtm /approve

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jglick, kvaps

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/nfs-ganesha-server-and-external-provisioner/blob/master/OWNERS)~~ [kvaps] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment