kubernetes-sigs / nfs-ganesha-server-and-external-provisioner

NFS Ganesha Server and Volume Provisioner.
Apache License 2.0
415 stars 141 forks source link

Changing mountOptions #119

Closed alexandrebunn closed 8 months ago

alexandrebunn commented 1 year ago

Is there a way to change the mountOptions of an existing pv and its pvc of a nfs-server deployed?

I've changed custom-values.yaml adding proto parameter and changing rsize and wsize but it didn't apply at pv definition.

See below the change at custom-values.yaml

  mountOptions:
    - vers=3
    - retrans=2
    - timeo=30
    - nosuid
    - rsize=8388608
    - wsize=8388608
    - proto=tcp

After apply with "helm upgrade -i"

The pv created didn't change these parameters (the proto=tcp parameter didn't take effect):

apiVersion: v1
kind: PersistentVolume
...
spec:
  accessModes:
  - ReadWriteMany
  capacity:
    storage: 30Gi
  claimRef:
    apiVersion: v1
    kind: PersistentVolumeClaim
    name: data-volume-ssd
    namespace: myns
    resourceVersion: "108524084"
    uid: 792cc3eb-825a-4948-b99d-bfa54b504481
  mountOptions:
  - vers=3
  - retrans=2
  - timeo=30
  - nosuid
  - rsize=8388608
  - wsize=8388608
k8s-triage-robot commented 1 year ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot commented 1 year ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

inzanez commented 1 year ago

As far as I can see, the mountOptions should be applied to the storageClass. I would assume that this resulted in new volumes being created with the changed mount options. For already existing PVs, you would have to edit the PV directly and then have the Kubernetes nodes re-mount that volume. I did that by restart the worker nodes one by one. I know, that might not be the best way but it definitely worked.

k8s-triage-robot commented 8 months ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

k8s-ci-robot commented 8 months ago

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to [this](https://github.com/kubernetes-sigs/nfs-ganesha-server-and-external-provisioner/issues/119#issuecomment-1901271564): >The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. > >This bot triages issues according to the following rules: >- After 90d of inactivity, `lifecycle/stale` is applied >- After 30d of inactivity since `lifecycle/stale` was applied, `lifecycle/rotten` is applied >- After 30d of inactivity since `lifecycle/rotten` was applied, the issue is closed > >You can: >- Reopen this issue with `/reopen` >- Mark this issue as fresh with `/remove-lifecycle rotten` >- Offer to help out with [Issue Triage][1] > >Please send feedback to sig-contributor-experience at [kubernetes/community](https://github.com/kubernetes/community). > >/close not-planned > >[1]: https://www.kubernetes.dev/docs/guide/issue-triage/ Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.