Prometheus compatible metrics

kubernetes-sigs / nfs-subdir-external-provisioner

Dynamic sub-dir volume provisioner on a remote NFS server.

Apache License 2.0

2.46k stars 740 forks source link

Prometheus compatible metrics #290

Open jcpunk opened 1 year ago

jcpunk commented 1 year ago

It would be nice if the pod had a prometheus compatible metrics endpoint (with optional ServiceMonitor from helm).

k8s-triage-robot commented 5 months ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue as fresh with /remove-lifecycle stale
Close this issue with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

jcpunk commented 5 months ago

I'm still interested in this

k8s-triage-robot commented 4 months ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue as fresh with /remove-lifecycle rotten
Close this issue with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

jcpunk commented 4 months ago

/remove-lifecycle rotten

k8s-triage-robot commented 1 month ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue as fresh with /remove-lifecycle stale
Close this issue with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

jcpunk commented 1 month ago

/remove-lifecycle stale

Starttoaster commented 1 month ago

This could be cool, but what metrics would you like to see exported?

jcpunk commented 4 weeks ago

Perhaps the volumes under management by this tool and any free space per source? Plus the standard CPU/RAM?

Starttoaster commented 4 weeks ago

Perhaps the volumes under management by this tool and any free space per source? Plus the standard CPU/RAM?

🤔 This provisioner doesn't currently know or even respect the free space available on the NFS server, so I'm not sure how that would be accomplished.

CPU/RAM sounds more like node_exporter's job than a metrics exporter built into this, to be honest.

Care to give more thoughts for either of those ideas? I'm not a maintainer here to be clear, but I own/maintain a fork of this repository. And was intrigued by the idea of adding metrics to it. I'm just not sure what metrics would really be appropriate for it. For what it's worth, I believe used space in a persistent volume is handled by kubelet's builtin metrics exporter (which is built into kubernetes installations.) And for CPU/RAM metrics of the NFS server, I think you would probably be better suited installing node_exporter on your NFS server. For CPU/RAM metrics of this provisioner, you're actually looking at using CAdvisor's metrics exporter (also built into kubernetes.)

jcpunk commented 4 weeks ago

I was thinking CPU/RAM usage of the nfs-subdir-external-provisioner process itself.

Maybe how many volumes were created by the provisioner?