search

kubernetes-sigs / node-feature-discovery-operator

Operator for managing Node Feature Discovery deployment
Apache License 2.0
66 stars 29 forks source link

controller: fix nfd-master cmdline args #151

Closed marquiz closed 2 years ago

marquiz commented 2 years ago

Remove quoting of the arg values which effectively make all of them broken.

marquiz commented 2 years ago

/cherry-pick release-0.4

k8s-infra-cherrypick-robot commented 2 years ago

@marquiz: once the present PR merges, I will cherry-pick it on top of release-0.4 in a new PR and assign it to you.

In response to [this](https://github.com/kubernetes-sigs/node-feature-discovery-operator/pull/151#issuecomment-1112055214): >/cherry-pick release-0.4 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
marquiz commented 2 years ago

/cherrypick release-0.4

k8s-infra-cherrypick-robot commented 2 years ago

@marquiz: once the present PR merges, I will cherry-pick it on top of release-0.4 in a new PR and assign it to you.

In response to [this](https://github.com/kubernetes-sigs/node-feature-discovery-operator/pull/151#issuecomment-1112056165): >/cherrypick release-0.4 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
k8s-ci-robot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArangoGutierrez, marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/node-feature-discovery-operator/blob/master/OWNERS)~~ [ArangoGutierrez,marquiz] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
k8s-infra-cherrypick-robot commented 2 years ago

@marquiz: new pull request created: #154

In response to [this](https://github.com/kubernetes-sigs/node-feature-discovery-operator/pull/151#issuecomment-1112056165): >/cherrypick release-0.4 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.