search

kubernetes-sigs / node-feature-discovery-operator

Operator for managing Node Feature Discovery deployment
Apache License 2.0
66 stars 29 forks source link

Dockerfile: define numeric user to run unprivileged #177

Closed ArangoGutierrez closed 1 year ago

ArangoGutierrez commented 1 year ago

This patch fix error:

Warning  Failed     65s (x7 over 2m21s)  kubelet            Error: container has runAsNonRoot and image has non-numeric user (nfd-operator), cannot verify user is non-root (pod: "node-feature-discovery-operator-controller-manager-6ccbd689t98z_node-feature-discovery-operator(89328c77-19c4-420d-8e09-61fca475630e)", container: manager)

By moving from named user nfd-operator to a numeric value user USER 65534:65534

Extra: define the generated make build binary path in gitignore to prevent future helm folders with same name to be ignored by git

ArangoGutierrez commented 1 year ago

/assign @marquiz

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArangoGutierrez, marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/node-feature-discovery-operator/blob/master/OWNERS)~~ [ArangoGutierrez,marquiz] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment