search

kubernetes-sigs / node-feature-discovery-operator

Operator for managing Node Feature Discovery deployment
Apache License 2.0
67 stars 29 forks source link

Don't create service if NodeFeature API is enabled #202

Closed ArangoGutierrez closed 1 year ago

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArangoGutierrez

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/node-feature-discovery-operator/blob/master/OWNERS)~~ [ArangoGutierrez] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ArangoGutierrez commented 1 year ago

/assign @marquiz

ArangoGutierrez commented 1 year ago

/test pull-node-feature-discovery-operator-verify

marquiz commented 1 year ago

Also, nit about the commit msg title. Start with capital letter and shorten a bit, e.g. Don't create service if NodeFeature API is enabled

yevgeny-shnaidman commented 1 year ago

looks good to me

marquiz commented 1 year ago

/retitle Don't create service if NodeFeature API is enabled

ArangoGutierrez commented 1 year ago

/retitle Don't create service if NodeFeature API is enabled