kubernetes-sigs / node-feature-discovery-operator

Operator for managing Node Feature Discovery deployment
Apache License 2.0
66 stars 29 forks source link

scripts/test-infra: add unit-tests.sh #207

Closed marquiz closed 6 months ago

marquiz commented 11 months ago

NOTE: another option would be to make this completely separate prow job

ArangoGutierrez commented 11 months ago

/retest

ArangoGutierrez commented 11 months ago

/hold

k8s-triage-robot commented 7 months ago

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

marquiz commented 7 months ago

Rebased /remove-lifecycle stale

marquiz commented 6 months ago

/assign @ArangoGutierrez @yevgeny-shnaidman

yevgeny-shnaidman commented 6 months ago

IMHO unit-test should be a separate prow job, but we can push this PR for now, and will revisit the prow job once the controllers have been rewritten

marquiz commented 6 months ago

/retitle scripts/test-infra: add unit-tests.sh

yevgeny-shnaidman commented 6 months ago

/lgtm

marquiz commented 6 months ago

/hold

marquiz commented 6 months ago

Let's see if prow obeys my late'ish hold. But it'd be good to sync up with https://github.com/kubernetes/test-infra/pull/32037

Merge the test-infra first. Then this PR

yevgeny-shnaidman commented 6 months ago

Let's see if prow obeys my late'ish hold. But it'd be good to sync up with kubernetes/test-infra#32037

Merge the test-infra first. Then this PR

Already looked at that PR. Once all the tests have passed, i will lgtm it

k8s-ci-robot commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArangoGutierrez, marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/node-feature-discovery-operator/blob/master/OWNERS)~~ [ArangoGutierrez,marquiz] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
marquiz commented 6 months ago

/unhold