search

kubernetes-sigs / node-feature-discovery-operator

Operator for managing Node Feature Discovery deployment
Apache License 2.0
66 stars 29 forks source link

Adding new controller template #212

Closed yevgeny-shnaidman closed 7 months ago

yevgeny-shnaidman commented 7 months ago

This PR is part of the refactoring effort. It contains the following: 1) new controller template implementation. It contains only the sequence of initialization for various components (master, worker, topology etc'). The actual implementation will be done via implementing the helper interface functions 2) unit-test for the controller 3) adding unit-test target to the Makefile 4) adding mockgen and golangci-lint downloading targets to the Makefile mockgen is used for generating the mock files for the interface.

yevgeny-shnaidman commented 7 months ago

/assign @ArangoGutierrez /assign @marquiz

ArangoGutierrez commented 7 months ago

Wow awesome! will take a look soon

yevgeny-shnaidman commented 7 months ago

Thanks @yevgeny-shnaidman for the PR. Just a few small notes from me.

To make this PR cleaner and leaner could we split out the changes to the Makefile in separate PR(s)?

@marquiz thank you for the review, moved the Makefile changes to a different PR

k8s-ci-robot commented 7 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marquiz, yevgeny-shnaidman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/node-feature-discovery-operator/blob/master/OWNERS)~~ [marquiz] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ArangoGutierrez commented 7 months ago

Thanks @yevgeny-shnaidman for the PR. Just a few small notes from me. To make this PR cleaner and leaner could we split out the changes to the Makefile in separate PR(s)?

@marquiz thank you for the review, moved the Makefile changes to a different PR

/lgtm