search

kubernetes-sigs / node-feature-discovery-operator

Operator for managing Node Feature Discovery deployment
Apache License 2.0
67 stars 29 forks source link

Adding topology deployment implementation #217

Closed yevgeny-shnaidman closed 8 months ago

yevgeny-shnaidman commented 9 months ago

On every reconciliation loop, the controller updates/creates topology daemonset if needed, based on the NFD CR spec.

yevgeny-shnaidman commented 9 months ago

/assign @chr15p

k8s-ci-robot commented 9 months ago

@yevgeny-shnaidman: GitHub didn't allow me to assign the following users: chr15p.

Note that only kubernetes-sigs members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see the contributor guide

In response to [this](https://github.com/kubernetes-sigs/node-feature-discovery-operator/pull/217#issuecomment-1975326418): >/assign @chr15p Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
yevgeny-shnaidman commented 8 months ago

/ping @marquiz

yevgeny-shnaidman commented 8 months ago

/ping @marquiz

yevgeny-shnaidman commented 8 months ago

ping @marquiz

k8s-ci-robot commented 8 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marquiz, yevgeny-shnaidman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/node-feature-discovery-operator/blob/master/OWNERS)~~ [marquiz] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
yevgeny-shnaidman commented 8 months ago

Thanks @yevgeny-shnaidman for the update. Looks good, I haven't tested it though 😅

@ArangoGutierrez @PiotrProkop PTAL

@marquiz curently we are just adding the building blocks. Once we have coded everything (master, worker, topology, prune , gc) we will add configs and then we can start really testing. I am pretty sure we will add more changes at that stage :)

ArangoGutierrez commented 8 months ago

/lgtm