search

kubernetes-sigs / node-feature-discovery-operator

Operator for managing Node Feature Discovery deployment
Apache License 2.0
66 stars 29 forks source link

setting finalizer on the NFD CR #220

Closed yevgeny-shnaidman closed 5 months ago

yevgeny-shnaidman commented 5 months ago

/assign @marquiz /assign @ArangoGutierrez

yevgeny-shnaidman commented 5 months ago

Thanks @yevgeny-shnaidman. Looks clean to me, albeit incomplete. So one question: is the other parts of the finalizer handling (hasFinalizer et al) supposed to be added by further PRs?

@marquiz my intention was to do it in a different PR, but you are right, it will be cleaner and clearer to do it in the same one. Added the hasFinalizer implementation. The finalization flow will be added in a different PR

yevgeny-shnaidman commented 5 months ago

ping @ArangoGutierrez

k8s-ci-robot commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArangoGutierrez, marquiz, yevgeny-shnaidman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/node-feature-discovery-operator/blob/master/OWNERS)~~ [ArangoGutierrez,marquiz] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment