search

kubernetes-sigs / node-feature-discovery-operator

Operator for managing Node Feature Discovery deployment
Apache License 2.0
66 stars 29 forks source link

Fixing prune job implementation #230

Closed yevgeny-shnaidman closed 4 months ago

yevgeny-shnaidman commented 4 months ago

No need to explicitly delete the prune job, since it will be deleted by the K8S scheduler once the NFD CR is removed from etcd. Additionally, if the job is explicitly deleted, then the code will attempt to recreate it a second time while the NFD CR is being deleted.

yevgeny-shnaidman commented 4 months ago

Please squash the 2 commits and fix the commit/PR message: "No need to explicitly delete the prune job, since it will be deleted by the K8S scheduler once the NFD CR is removed from etcd. Additionally, if the job is explicitly deleted, then the code will attempt to recreate it a second time while the NFD CR is being deleted."

Done

k8s-ci-robot commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArangoGutierrez, yevgeny-shnaidman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/node-feature-discovery-operator/blob/master/OWNERS)~~ [ArangoGutierrez] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment