search

kubernetes-sigs / node-feature-discovery-operator

Operator for managing Node Feature Discovery deployment
Apache License 2.0
66 stars 29 forks source link

Pivoting to new operator implementation #232

Closed yevgeny-shnaidman closed 3 months ago

yevgeny-shnaidman commented 4 months ago

Starting from this commit, operator will use the new controller implementation. The old implementation code will be deleted in the subsequent PRs

yevgeny-shnaidman commented 4 months ago

/assign @marquiz

marquiz commented 4 months ago

Thanks @yevgeny-shnaidman for the PR. I'll check it in detail a bit later. First question (after a 30s skim-through): are the logger changes related/dependent on this (or could they be a separate PR)?

yevgeny-shnaidman commented 4 months ago

Thanks @yevgeny-shnaidman for the PR. I'll check it in detail a bit later. First question (after a 30s skim-through): are the logger changes related/dependent on this (or could they be a separate PR)?

They are dependent on switching to the new controller. Unless we do them, we will see some warnings in the manager log

marquiz commented 4 months ago

They are dependent on switching to the new controller. Unless we do them, we will see some warnings in the manager log

Kinda useless nitting, but where do we get warnings? Looking at the PR now we only change logger in main.go which shouldn't affect any other parts of the codebase 🧐 So it looks to me like the logger changes could/should be just a separate PR.

yevgeny-shnaidman commented 4 months ago

They are dependent on switching to the new controller. Unless we do them, we will see some warnings in the manager log

Kinda useless nitting, but where do we get warnings? Looking at the PR now we only change logger in main.go which shouldn't affect any other parts of the codebase 🧐 So it looks to me like the logger changes could/should be just a separate PR.

We get the warning in the manager log, but those warnings are coming from the controller-runtime code. I can split this PR into 2 ( first the actual pivot and then the logging PR), but i wanted to keep it altogether so that after this PR the operator can be seen deployed and running with logs.

k8s-ci-robot commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marquiz, yevgeny-shnaidman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/node-feature-discovery-operator/blob/master/OWNERS)~~ [marquiz] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
yevgeny-shnaidman commented 3 months ago

ping @ArangoGutierrez

ArangoGutierrez commented 3 months ago

ping @ArangoGutierrez

Sorry I was traveling last week, will review this one this week

yevgeny-shnaidman commented 3 months ago

/ping @ArangoGutierrez

yevgeny-shnaidman commented 3 months ago

ping @ArangoGutierrez

marquiz commented 3 months ago

/lgtm