search

kubernetes-sigs / node-feature-discovery-operator

Operator for managing Node Feature Discovery deployment
Apache License 2.0
66 stars 29 forks source link

sync operator nfr crds with operand helm nfr crds #236

Closed chr15p closed 3 months ago

chr15p commented 3 months ago

sync operator nfr crds with operand helm nfr crds and also standardise on nodefeaturerules.nfd.k8s-sigs.io

The crds here do not support annotations:, extendedResources: and matchFeatures.matchName in their rules:. They are supported by the CRDs supplied by the operand helm charts (which as I understand it are correct) so it make sense to sync them over. This PR does that.

We also have confusion on the api version for rules with nfd.k8s-sigs.io/v1alpha1 being used in most places, and nfd.kubernetes.io/v1alpha1 in the samples, and manifest files. k8s-sigs.io is used by the operand helm charts so this PR updates to that, removing the extra crd file (that wasn't referenced by kustomize anyway), and renaming the sample yaml file.

k8s-ci-robot commented 3 months ago

Hi @chr15p. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
marquiz commented 3 months ago

/ok-to-test

k8s-ci-robot commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chr15p, marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/node-feature-discovery-operator/blob/master/OWNERS)~~ [marquiz] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
yevgeny-shnaidman commented 3 months ago

/lgtm