search

kubernetes-sigs / node-feature-discovery-operator

Operator for managing Node Feature Discovery deployment
Apache License 2.0
67 stars 29 forks source link

Getting rid of pkg/utils #238

Closed yevgeny-shnaidman closed 5 months ago

yevgeny-shnaidman commented 5 months ago

pkg utils is used for solely for getting the WATCH_NAMESPACE env variable . We don't need a separate public package just for that functionality. Moving the function into the main. In addition, since WATCH_NAMESPACEmust be set in the deployment, the operator will fail in case the variable is not defined, instead of just logging a warrning

yevgeny-shnaidman commented 5 months ago

/assign @marquiz

yevgeny-shnaidman commented 5 months ago

Should we drop pkg/utils/utils.go file?

We will do it in the same PR for all the irrelevant directories (pkg, controllers, build/assets)

k8s-ci-robot commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marquiz, yevgeny-shnaidman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/node-feature-discovery-operator/blob/master/OWNERS)~~ [marquiz] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment