k8s-ci-robot
commented
5 months ago Hi @chr15p. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
yevgeny-shnaidman
ArangoGutierrez
chr15p
The helm charts are out of sync with those used by the kustomize installer, this commit copies them over and converts them to use helm variables. This should now mean you get the same set of crds, serviceaccounts, bindings, etc. whichever of the two installation methods you use, and nfd should Just Work (tm) either way.
Hopefully by breaking the objects out into the multi-file layout used by kustomize it will be easier to spot differences and keep the two installation methods in sync in the future.
(note: Most rbac objects should have the chart fullname in their name but the serviceaccount names are hardwired in the operator reconciliation code so they can't be templated and are left as nfd-worker, nfd-master etc)