search

kubernetes-sigs / node-feature-discovery-operator

Operator for managing Node Feature Discovery deployment
Apache License 2.0
66 stars 29 forks source link

Using dedicated ServiceAccount for manager pod #244

Closed yevgeny-shnaidman closed 2 months ago

yevgeny-shnaidman commented 2 months ago

currently manager pod is using the default service account in order to increase readability and to avoid confusion we will use a dedicated ServiceAccount instead of default

ArangoGutierrez commented 2 months ago

And the Helm Deployment?

yevgeny-shnaidman commented 2 months ago

And the Helm Deployment?

Is there a current use for Operator helm deployment? My thought was that helm deployment should be re-visited once we unify the repos

yevgeny-shnaidman commented 2 months ago

nit: typo in the commit message (and PR title) s/dedecated/dedicated/

Fixed

k8s-ci-robot commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marquiz, yevgeny-shnaidman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/node-feature-discovery-operator/blob/master/OWNERS)~~ [marquiz] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ArangoGutierrez commented 2 months ago

And the Helm Deployment?

Is there a current use for Operator helm deployment? My thought was that helm deployment should be re-visited once we unify the repos

forgot about that conversation /lgtm