search

kubernetes-sigs / node-feature-discovery

Node feature discovery for Kubernetes
Apache License 2.0
790 stars 243 forks source link

Enable codecov reporting #1033

Closed marquiz closed 1 year ago

marquiz commented 1 year ago

What would you like to be added:

Now that https://github.com/kubernetes/org/issues/3084 has been solved, we could enable codecov reporing in NFD. We should probably separate unit tests from the image build (Dockerfile) into a distinct prow job. An outline of sub-tasks (might be missing some)

  1. Enable coverage output in Makefile test: target
  2. Add new presubmit-test Prow job
  3. Get codecov token added as a secret in the k8s test-infra cluster
  4. Add codecov reporting in the NFD test-infra script (`scripts/test-infra/)

Why is this needed:

Improve development process

fmuyassarov commented 1 year ago

+1 for the codecov and I guess it makes sense to decouple the unit tests from the Dockerfile into its own job.

ArangoGutierrez commented 1 year ago

+1

fmuyassarov commented 1 year ago

@marquiz do you plan to work on this ?

marquiz commented 1 year ago

@marquiz do you plan to work on this ?

Feel free to help out here 😉 TBH, I don't know if I have time to take care of this in the near future

AhmedGrati commented 1 year ago

@marquiz I can work on it once I finish my current PR.

fmuyassarov commented 1 year ago

Hi @AhmedGrati. Thanks for offering help. But I had it halfway. If you don't mind let me finish it and if I don't for some reason I will let you know here. /assign

marquiz commented 1 year ago

I don't think we're quite ready yet /reopen

k8s-ci-robot commented 1 year ago

@marquiz: Reopened this issue.

In response to [this](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1033#issuecomment-1458645635): >I don't think we're quite ready yet >/reopen Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
ArangoGutierrez commented 1 year ago

I think we are ready here, right @fmuyassarov

fmuyassarov commented 1 year ago

I believe yes. This is done via https://github.com/kubernetes-sigs/node-feature-discovery/pull/1201, https://github.com/kubernetes-sigs/node-feature-discovery/pull/1200, https://github.com/kubernetes-sigs/node-feature-discovery/pull/1199, https://github.com/kubernetes-sigs/node-feature-discovery/pull/1194, https://github.com/kubernetes-sigs/node-feature-discovery/pull/1095, https://github.com/kubernetes-sigs/node-feature-discovery/pull/1085, https://github.com/kubernetes-sigs/node-feature-discovery/pull/1069. /close

k8s-ci-robot commented 1 year ago

@fmuyassarov: Closing this issue.

In response to [this](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1033#issuecomment-1534464409): >I believe yes. This is done via https://github.com/kubernetes-sigs/node-feature-discovery/pull/1201, https://github.com/kubernetes-sigs/node-feature-discovery/pull/1200, https://github.com/kubernetes-sigs/node-feature-discovery/pull/1199, https://github.com/kubernetes-sigs/node-feature-discovery/pull/1194, https://github.com/kubernetes-sigs/node-feature-discovery/pull/1095, https://github.com/kubernetes-sigs/node-feature-discovery/pull/1085, https://github.com/kubernetes-sigs/node-feature-discovery/pull/1069. >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.