Closed marquiz closed 1 month ago
/assign @ArangoGutierrez
Name | Link |
---|---|
Latest commit | 121345472da17a48a1b29dbb0376b407d5f66939 |
Latest deploy log | https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/6644c0377b6ce2000826f4ad |
Deploy Preview | https://deploy-preview-1707--kubernetes-sigs-nfd.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: marquiz, TessaIO
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Unit tests fixed /assign @TessaIO
Fixes in documentation
/lgtm
LGTM label has been added.
Attention: Patch coverage is 0%
with 8 lines
in your changes are missing coverage. Please review.
Project coverage is 39.85%. Comparing base (
5d9266b
) to head (1213454
).
/retest
Now that we have support for feature gates deprecate the autoDefaultNs config option of nfd-master and replace it with a new alpha feature gate DisableAutoPrefix (defaults to false). Using a feature gate to handle and communicate these kind of changes, where the default behavior is intended to be changed in a future release, feels much more natural than using random flags/options.
The combined logic of the feature gate and the config option is a logical OR over disabling auto-prefixing. That is, auto-prefixing is disabled if either the feature gate or the config options is used set to disable it: