Re-add -enable-nodefeature-api cmdline flag

[marquiz]

Bring back the -enable-nodefeature-api command line flag and the corresponding enableNodeFeatureApi helm config value that were removed without deprecation when the NodeFeatureAPI feature gate was introduced. The thinking behind this change is to not break existing users (without warning) unless totally unavoidable. Now the -enable-nodefeature-api flag is marked as deprecated and slated for removal in NFD v0.17.

The NodeFeatureAPI feature gate and the -enable-nodefeature-api flag work together so that the NodeFeature API is disabled (gRPC is enabled, instead) if either of them is set to false.

This patch selectively reverts parts of 06c4733bc5c5c3881edd18875114e91ef922fe2f.

[marquiz]

/assign @ArangoGutierrez

[netlify[bot]]

✅ Deploy Preview for kubernetes-sigs-nfd ready!

Name	Link
🔨 Latest commit	560bd11d8558ef9be06bfe1050f48bd1d24ef92e
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/6645bb98f664f10008b157ed
😎 Deploy Preview	https://deploy-preview-1708--kubernetes-sigs-nfd.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[marquiz]

Rebased. @ArangoGutierrez PTAL

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 64b556353a8ade498265b335376104373d575812

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArangoGutierrez, marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/node-feature-discovery/blob/master/OWNERS)~~ [ArangoGutierrez,marquiz] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

[codecov[bot]]

Codecov Report

Attention: Patch coverage is 31.25000% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 40.26%. Comparing base (fc38294) to head (560bd11).

Additional details and impacted files

[](https://app.codecov.io/gh/kubernetes-sigs/node-feature-discovery/pull/1708?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubernetes-sigs) ```diff @@ Coverage Diff @@ ## master #1708 +/- ## ========================================== + Coverage 39.85% 40.26% +0.40% ========================================== Files 80 80 Lines 6839 6849 +10 ========================================== + Hits 2726 2758 +32 + Misses 3859 3835 -24 - Partials 254 256 +2 ``` | [Files](https://app.codecov.io/gh/kubernetes-sigs/node-feature-discovery/pull/1708?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubernetes-sigs) | Coverage Δ | | |---|---|---| | [pkg/nfd-worker/nfd-worker.go](https://app.codecov.io/gh/kubernetes-sigs/node-feature-discovery/pull/1708?src=pr&el=tree&filepath=pkg%2Fnfd-worker%2Fnfd-worker.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubernetes-sigs#diff-cGtnL25mZC13b3JrZXIvbmZkLXdvcmtlci5nbw==) | `52.55% <50.00%> (ø)` | | | [cmd/nfd-worker/main.go](https://app.codecov.io/gh/kubernetes-sigs/node-feature-discovery/pull/1708?src=pr&el=tree&filepath=cmd%2Fnfd-worker%2Fmain.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubernetes-sigs#diff-Y21kL25mZC13b3JrZXIvbWFpbi5nbw==) | `54.31% <60.00%> (+0.25%)` | :arrow_up: | | [pkg/nfd-master/nfd-master.go](https://app.codecov.io/gh/kubernetes-sigs/node-feature-discovery/pull/1708?src=pr&el=tree&filepath=pkg%2Fnfd-master%2Fnfd-master.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubernetes-sigs#diff-cGtnL25mZC1tYXN0ZXIvbmZkLW1hc3Rlci5nbw==) | `44.02% <25.00%> (+3.01%)` | :arrow_up: | | [cmd/nfd-master/main.go](https://app.codecov.io/gh/kubernetes-sigs/node-feature-discovery/pull/1708?src=pr&el=tree&filepath=cmd%2Fnfd-master%2Fmain.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubernetes-sigs#diff-Y21kL25mZC1tYXN0ZXIvbWFpbi5nbw==) | `0.00% <0.00%> (ø)` | |