kubernetes-sigs / node-feature-discovery

Node feature discovery for Kubernetes
Apache License 2.0
725 stars 228 forks source link

nfd-worker: improved log when creating NodeFeature object #1713

Closed marquiz closed 1 month ago

marquiz commented 1 month ago

Don't log an empty NodeFeature object.

netlify[bot] commented 1 month ago

Deploy Preview for kubernetes-sigs-nfd ready!

Name Link
Latest commit 649036977ef4030dc1c06e3dc0edeb6f62512b52
Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/664f2b192553020008528b3d
Deploy Preview https://deploy-preview-1713--kubernetes-sigs-nfd.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

marquiz commented 1 month ago

/assign @ArangoGutierrez

k8s-ci-robot commented 1 month ago

LGTM label has been added.

Git tree hash: e4c921d9ed25399ebfe43bf4fafa9055a951067d

k8s-ci-robot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArangoGutierrez, marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/node-feature-discovery/blob/master/OWNERS)~~ [ArangoGutierrez,marquiz] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 42.81%. Comparing base (6644b6a) to head (6490369). Report is 4 commits behind head on master.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/kubernetes-sigs/node-feature-discovery/pull/1713/graphs/tree.svg?width=650&height=150&src=pr&token=mEZgtJQ1vg&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubernetes-sigs)](https://app.codecov.io/gh/kubernetes-sigs/node-feature-discovery/pull/1713?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubernetes-sigs) ```diff @@ Coverage Diff @@ ## master #1713 +/- ## ========================================== + Coverage 40.26% 42.81% +2.54% ========================================== Files 80 81 +1 Lines 6849 7441 +592 ========================================== + Hits 2758 3186 +428 - Misses 3835 3965 +130 - Partials 256 290 +34 ``` | [Files](https://app.codecov.io/gh/kubernetes-sigs/node-feature-discovery/pull/1713?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubernetes-sigs) | Coverage Ξ” | | |---|---|---| | [pkg/nfd-worker/nfd-worker.go](https://app.codecov.io/gh/kubernetes-sigs/node-feature-discovery/pull/1713?src=pr&el=tree&filepath=pkg%2Fnfd-worker%2Fnfd-worker.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubernetes-sigs#diff-cGtnL25mZC13b3JrZXIvbmZkLXdvcmtlci5nbw==) | `52.55% <0.00%> (ΓΈ)` | | ... and [5 files with indirect coverage changes](https://app.codecov.io/gh/kubernetes-sigs/node-feature-discovery/pull/1713/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubernetes-sigs)