kubernetes-sigs / node-feature-discovery

Node feature discovery for Kubernetes
Apache License 2.0
725 stars 228 forks source link

api/nfd: document all undocumented fields in the types #1714

Closed marquiz closed 1 month ago

marquiz commented 1 month ago

/assign @ArangoGutierrez

netlify[bot] commented 1 month ago

Deploy Preview for kubernetes-sigs-nfd ready!

Name Link
Latest commit b3d6282d2c0aa037d182648bfa45ffcc447d034b
Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/664fabf45450b8000926e31c
Deploy Preview https://deploy-preview-1714--kubernetes-sigs-nfd.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

ArangoGutierrez commented 1 month ago

/test pull-node-feature-discovery-build-image-cross-generic

k8s-ci-robot commented 1 month ago

LGTM label has been added.

Git tree hash: 28cc3eb2ba4b56cd2a3e0e071ebe40d2f773fc3f

k8s-ci-robot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArangoGutierrez, marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/node-feature-discovery/blob/master/OWNERS)~~ [ArangoGutierrez,marquiz] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 39.04%. Comparing base (f3051f2) to head (b3d6282).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/kubernetes-sigs/node-feature-discovery/pull/1714/graphs/tree.svg?width=650&height=150&src=pr&token=mEZgtJQ1vg&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubernetes-sigs)](https://app.codecov.io/gh/kubernetes-sigs/node-feature-discovery/pull/1714?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubernetes-sigs) ```diff @@ Coverage Diff @@ ## master #1714 +/- ## ======================================= Coverage 39.04% 39.04% ======================================= Files 80 80 Lines 7069 7069 ======================================= Hits 2760 2760 Misses 4049 4049 Partials 260 260 ```