kubernetes-sigs / node-feature-discovery

Node feature discovery for Kubernetes
Apache License 2.0
725 stars 228 forks source link

source/cpu: disable AVX10 label #1715

Closed marquiz closed 1 month ago

marquiz commented 1 month ago

Disable AVX10 as unnecessary as AVX10_LEVEL is better suited for checking AVX10 compatibility. There is not yet any hardware with the feature so disabling it shouldn't cause problems for users.

netlify[bot] commented 1 month ago

Deploy Preview for kubernetes-sigs-nfd ready!

Name Link
Latest commit ece6076dd49fa5264f76fec3c216971724c92a9b
Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/6650713e612ebc0008fb7632
Deploy Preview https://deploy-preview-1715--kubernetes-sigs-nfd.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

marquiz commented 1 month ago

Depends on #1673 /hold

/assign @ArangoGutierrez

ArangoGutierrez commented 1 month ago

/hold cancel

ArangoGutierrez commented 1 month ago

/test all

ArangoGutierrez commented 1 month ago

/test all

k8s-ci-robot commented 1 month ago

LGTM label has been added.

Git tree hash: b3441d6bb28b082ad49d94521ad7c2f690f659a6

k8s-ci-robot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArangoGutierrez, marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/node-feature-discovery/blob/master/OWNERS)~~ [ArangoGutierrez,marquiz] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 39.47%. Comparing base (814255b) to head (ece6076). Report is 2 commits behind head on master.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/kubernetes-sigs/node-feature-discovery/pull/1715/graphs/tree.svg?width=650&height=150&src=pr&token=mEZgtJQ1vg&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubernetes-sigs)](https://app.codecov.io/gh/kubernetes-sigs/node-feature-discovery/pull/1715?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubernetes-sigs) ```diff @@ Coverage Diff @@ ## master #1715 +/- ## ========================================== - Coverage 39.60% 39.47% -0.13% ========================================== Files 80 80 Lines 7141 7194 +53 ========================================== + Hits 2828 2840 +12 - Misses 4054 4088 +34 - Partials 259 266 +7 ``` | [Files](https://app.codecov.io/gh/kubernetes-sigs/node-feature-discovery/pull/1715?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubernetes-sigs) | Coverage Δ | | |---|---|---| | [source/cpu/cpu.go](https://app.codecov.io/gh/kubernetes-sigs/node-feature-discovery/pull/1715?src=pr&el=tree&filepath=source%2Fcpu%2Fcpu.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubernetes-sigs#diff-c291cmNlL2NwdS9jcHUuZ28=) | `27.11% <100.00%> (+0.03%)` | :arrow_up: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/kubernetes-sigs/node-feature-discovery/pull/1715/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubernetes-sigs)