search

kubernetes-sigs / node-feature-discovery

Node feature discovery for Kubernetes
Apache License 2.0
725 stars 228 forks source link

Revert "build(deps): bump actions/checkout from 1 to 4" #1720

Closed marquiz closed 1 month ago

marquiz commented 1 month ago

Checkout v4 does some strange mangling of tags, basically overwrites our signed/annotated tag with something like:

/usr/bin/git -c protocol.version=2 fetch --no-tags --prune \ --no-recurse-submodules origin \ +2e93c3fd478b6631dd7bda9c6ec66a9f99cafaa8:refs/tags/v0.16.0

Which breaks our gh-pages build on release branches/tags.

This reverts commit 130ef1070d4f90e2a44959a68a576ef11ad93c4f.

marquiz commented 1 month ago

/cherry-pick release-0.16

k8s-infra-cherrypick-robot commented 1 month ago

@marquiz: once the present PR merges, I will cherry-pick it on top of release-0.16 in a new PR and assign it to you.

In response to [this](https://github.com/kubernetes-sigs/node-feature-discovery/pull/1720#issuecomment-2133892735): >/cherry-pick release-0.16 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
netlify[bot] commented 1 month ago

Deploy Preview for kubernetes-sigs-nfd ready!

Name Link
Latest commit 3c47b4f32f8c4599b6d7b4143d68c2368af66b83
Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/6654ca9a45ef800008ab8cbf
Deploy Preview https://deploy-preview-1720--kubernetes-sigs-nfd.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

k8s-ci-robot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArangoGutierrez, marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/node-feature-discovery/blob/master/OWNERS)~~ [ArangoGutierrez,marquiz] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
k8s-ci-robot commented 1 month ago

LGTM label has been added.

Git tree hash: b0202c10d0258052284ed1e93c1719330e0956b4

k8s-infra-cherrypick-robot commented 1 month ago

@marquiz: new pull request created: #1721

In response to [this](https://github.com/kubernetes-sigs/node-feature-discovery/pull/1720#issuecomment-2133892735): >/cherry-pick release-0.16 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.