kubernetes-sigs / node-feature-discovery

Node feature discovery for Kubernetes
Apache License 2.0
725 stars 228 forks source link

deployment/helm: enable specifying additional cmdline args #1726

Open marquiz opened 1 month ago

netlify[bot] commented 1 month ago

Deploy Preview for kubernetes-sigs-nfd ready!

Name Link
Latest commit a088de7333bf987d68e09328fb3388e8415c96d7
Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/66561006cd7ae700086fbe6b
Deploy Preview https://deploy-preview-1726--kubernetes-sigs-nfd.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

ArangoGutierrez commented 1 month ago

why is this needed? we have all flags covered no?

k8s-ci-robot commented 1 day ago

LGTM label has been added.

Git tree hash: 2c92e39b92831325cd8d3a929e4c1c20053b497f

k8s-ci-robot commented 1 day ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArangoGutierrez, marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/node-feature-discovery/blob/master/OWNERS)~~ [ArangoGutierrez,marquiz] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
codecov[bot] commented 18 hours ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 39.54%. Comparing base (560905f) to head (a088de7). Report is 20 commits behind head on master.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/kubernetes-sigs/node-feature-discovery/pull/1726/graphs/tree.svg?width=650&height=150&src=pr&token=mEZgtJQ1vg&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubernetes-sigs)](https://app.codecov.io/gh/kubernetes-sigs/node-feature-discovery/pull/1726?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubernetes-sigs) ```diff @@ Coverage Diff @@ ## master #1726 +/- ## ======================================= Coverage 39.54% 39.54% ======================================= Files 80 80 Lines 7153 7153 ======================================= Hits 2829 2829 Misses 4064 4064 Partials 260 260 ```