search

kubernetes-sigs / node-feature-discovery

Node feature discovery for Kubernetes
Apache License 2.0
725 stars 228 forks source link

topology-updater: properly handle IPv6 from NODE_ADDRESS #1729

Closed marquiz closed 4 weeks ago

marquiz commented 1 month ago

Fix the usage of IPv6 addresses for default kubelet configz endpoint.

The default host:port we use for kubelet configz endpoint is ${NODE_ADDRESS}:10250. Previously we errored out if NODE_ADDRESS was an IPv6 address because we used an incorrect notation (without brackets). The (IPv6) needs to be enclosed in brackets if specifying the port.

Fixes #1727

k8s-ci-robot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/node-feature-discovery/blob/master/OWNERS)~~ [marquiz] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
marquiz commented 1 month ago

Need to verify this

/hold

marquiz commented 1 month ago

/assign @PiotrProkop

marquiz commented 1 month ago

/cherry-pick release-0.16 /cherry-pick release-0.15

k8s-infra-cherrypick-robot commented 1 month ago

@marquiz: once the present PR merges, I will cherry-pick it on top of release-0.16 in a new PR and assign it to you.

In response to [this](https://github.com/kubernetes-sigs/node-feature-discovery/pull/1729#issuecomment-2139366127): >/cherry-pick release-0.16 >/cherry-pick release-0.15 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
netlify[bot] commented 1 month ago

Deploy Preview for kubernetes-sigs-nfd ready!

Name Link
Latest commit dfbd63b728a568428aec3912d04be9cbe55d6487
Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/665ef8666250ab00088f9c93
Deploy Preview https://deploy-preview-1729--kubernetes-sigs-nfd.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

craigcabrey commented 1 month ago

thanks!

marquiz commented 4 weeks ago

Tested this on ipv6 cluster on kind. Seems to work as expected. @PiotrProkop PTAL /unhold

PiotrProkop commented 4 weeks ago

/lgtm

k8s-ci-robot commented 4 weeks ago

LGTM label has been added.

Git tree hash: 09c59227af5365d10321e63fb1d94598f658155f

marquiz commented 4 weeks ago

/retest

marquiz commented 4 weeks ago

Force-pushed to re-run the netlify stuff. @PiotrProkop PTAL

marquiz commented 4 weeks ago

Oh, it didn't remove the lgtm label. @PiotrProkop nevermind :)

codecov[bot] commented 4 weeks ago

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 39.51%. Comparing base (560905f) to head (dfbd63b).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/kubernetes-sigs/node-feature-discovery/pull/1729/graphs/tree.svg?width=650&height=150&src=pr&token=mEZgtJQ1vg&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubernetes-sigs)](https://app.codecov.io/gh/kubernetes-sigs/node-feature-discovery/pull/1729?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubernetes-sigs) ```diff @@ Coverage Diff @@ ## master #1729 +/- ## ========================================== - Coverage 39.54% 39.51% -0.04% ========================================== Files 80 80 Lines 7153 7160 +7 ========================================== Hits 2829 2829 - Misses 4064 4071 +7 Partials 260 260 ``` | [Files](https://app.codecov.io/gh/kubernetes-sigs/node-feature-discovery/pull/1729?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubernetes-sigs) | Coverage Δ | | |---|---|---| | [cmd/nfd-topology-updater/main.go](https://app.codecov.io/gh/kubernetes-sigs/node-feature-discovery/pull/1729?src=pr&el=tree&filepath=cmd%2Fnfd-topology-updater%2Fmain.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubernetes-sigs#diff-Y21kL25mZC10b3BvbG9neS11cGRhdGVyL21haW4uZ28=) | `43.90% <0.00%> (-4.10%)` | :arrow_down: |
k8s-infra-cherrypick-robot commented 4 weeks ago

@marquiz: new pull request created: #1731

In response to [this](https://github.com/kubernetes-sigs/node-feature-discovery/pull/1729#issuecomment-2139366127): >/cherry-pick release-0.16 >/cherry-pick release-0.15 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
k8s-infra-cherrypick-robot commented 4 weeks ago

@marquiz: new pull request created: #1732

In response to [this](https://github.com/kubernetes-sigs/node-feature-discovery/pull/1729#issuecomment-2139366127): >/cherry-pick release-0.16 >/cherry-pick release-0.15 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.