search

kubernetes-sigs / node-feature-discovery

Node feature discovery for Kubernetes
Apache License 2.0
769 stars 239 forks source link

Fix the problem with starting the master with empty cache #1739

Closed zhshishkin closed 3 months ago

zhshishkin commented 3 months ago

We faced the problem when master deleted some of labels on start. Sometimes he doesn't gets NodeFeatures when they are present in cluster because of empty cache in informer

linux-foundation-easycla[bot] commented 3 months ago

CLA Signed


The committers listed above are authorized under a signed CLA.

k8s-ci-robot commented 3 months ago

Welcome @IbirbyZh!

It looks like this is your first PR to kubernetes-sigs/node-feature-discovery 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/node-feature-discovery has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot commented 3 months ago

Hi @IbirbyZh. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
netlify[bot] commented 3 months ago

Deploy Preview for kubernetes-sigs-nfd ready!

Name Link
Latest commit 2f9801b55492aef65ae24ec3300d02f70acf4d31
Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/666724c5496afc00081a1c0b
Deploy Preview https://deploy-preview-1739--kubernetes-sigs-nfd.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

k8s-ci-robot commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IbirbyZh, marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/node-feature-discovery/blob/master/OWNERS)~~ [marquiz] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
marquiz commented 3 months ago

@IbirbyZh please sign the CLA so that we can get the patch merged

/cherry-pick release-0.16

k8s-infra-cherrypick-robot commented 3 months ago

@marquiz: once the present PR merges, I will cherry-pick it on top of release-0.16 in a new PR and assign it to you.

In response to [this](https://github.com/kubernetes-sigs/node-feature-discovery/pull/1739#issuecomment-2158812810): >@IbirbyZh please sign the CLA so that we can get the patch merged > >/cherry-pick release-0.16 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
marquiz commented 3 months ago

/assign @PiotrProkop

PiotrProkop commented 3 months ago

/lgtm

k8s-ci-robot commented 3 months ago

LGTM label has been added.

Git tree hash: 6c2a333b77461df889f10db4de46c2d31d6c0391

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 39.50%. Comparing base (4628ea8) to head (2f9801b).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/kubernetes-sigs/node-feature-discovery/pull/1739/graphs/tree.svg?width=650&height=150&src=pr&token=mEZgtJQ1vg&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubernetes-sigs)](https://app.codecov.io/gh/kubernetes-sigs/node-feature-discovery/pull/1739?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubernetes-sigs) ```diff @@ Coverage Diff @@ ## master #1739 +/- ## ========================================== - Coverage 39.51% 39.50% -0.01% ========================================== Files 80 80 Lines 7160 7161 +1 ========================================== Hits 2829 2829 - Misses 4071 4072 +1 Partials 260 260 ``` | [Files](https://app.codecov.io/gh/kubernetes-sigs/node-feature-discovery/pull/1739?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubernetes-sigs) | Coverage Δ | | |---|---|---| | [pkg/nfd-master/nfd-api-controller.go](https://app.codecov.io/gh/kubernetes-sigs/node-feature-discovery/pull/1739?src=pr&el=tree&filepath=pkg%2Fnfd-master%2Fnfd-api-controller.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubernetes-sigs#diff-cGtnL25mZC1tYXN0ZXIvbmZkLWFwaS1jb250cm9sbGVyLmdv) | `9.01% <0.00%> (-0.08%)` | :arrow_down: |
k8s-infra-cherrypick-robot commented 3 months ago

@marquiz: new pull request created: #1740

In response to [this](https://github.com/kubernetes-sigs/node-feature-discovery/pull/1739#issuecomment-2158812810): >@IbirbyZh please sign the CLA so that we can get the patch merged > >/cherry-pick release-0.16 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.