search

kubernetes-sigs / node-feature-discovery

Node feature discovery for Kubernetes
Apache License 2.0
725 stars 228 forks source link

Migrate to Community CI By August 1st #1747

Open BenTheElder opened 1 week ago

BenTheElder commented 1 week ago

Node feature discovery CI still needs migrating, per https://groups.google.com/a/kubernetes.io/g/dev/c/p6PAML90ZOU

You can find jobs listed in:

https://github.com/kubernetes/test-infra/blob/master/docs/job-migration-todo.md

(see e.g. jobs with name containing "node-feature-discovery")

ArangoGutierrez commented 1 day ago

https://github.com/kubernetes/test-infra/pull/32887

ArangoGutierrez commented 1 day ago

https://github.com/kubernetes/test-infra/pull/32887 Merged! /close

k8s-ci-robot commented 1 day ago

@ArangoGutierrez: Closing this issue.

In response to [this](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1747#issuecomment-2204070842): >https://github.com/kubernetes/test-infra/pull/32887 Merged! >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
BenTheElder commented 1 day ago

You should probably double check that the e2e job is still working, in particular, it might need some follow-ups.

ArangoGutierrez commented 1 day ago

You should probably double check that the e2e job is still working, in particular, it might need some follow-ups.

you are right, celebrating too fast.... /reopen

k8s-ci-robot commented 1 day ago

@ArangoGutierrez: Reopened this issue.

In response to [this](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1747#issuecomment-2204076382): >> You should probably double check that the e2e job is still working, in particular, it might need some follow-ups. > >you are right, celebrating too fast.... >/reopen Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
BenTheElder commented 19 hours ago

since it's a postsubmit, we won't know until a PR merges.

I could manually trigger it to run again for an existing merge but with the latest config, let's try that ...

BenTheElder commented 19 hours ago

https://prow.k8s.io/?job=postsubmit-node-feature-discovery-e2e-test

BenTheElder commented 19 hours ago

If we check the events for the failed run:

Error: secret "node-feature-discovery-ci" not found

Whatever this secret was enabling will need to be replicated using only what is provided by the k8s community infra.

I don't have context on what this job attempts to do and why it had a custom secret. Does anyone know what this secret was for?

If it's just to use a GCP project, you can instead rent one from boskos, kubetest(2) provide facilities for this.

it actually kinda looks like https://github.com/kubernetes-sigs/node-feature-discovery/blob/master/scripts/test-infra/test-e2e.sh is doing things on AWS?

BenTheElder commented 19 hours ago

in which case we should move it to the EKS cluster and figure out how to replicate the infra over there (not my speciality but .. we can reach out in #sig-k8s-infra)