Closed marquiz closed 1 week ago
At least fix #1841 (#1848)
Maybe also #1878?
We could take that. But host networks also requires #1885 which is a bit more controversial for a patch release
But host networks also requires #1885 which is a bit more controversial for a patch release
From my perspective, this PR doesn’t introduce any changes to the core logic or default behavior, so the impact should be minimal. The Helm value retains a default setting if not explicitly configured. Given that, I believe it should be safe to include in the patch release.
@tobiasgiese fair enough. I agree that #1885 is very low risk, let's cherry-pick
GitHub release page: https://github.com/kubernetes-sigs/node-feature-discovery/releases/tag/v0.16.5
Also the helm repo is published
❯ helm search repo nfd
NAME CHART VERSION APP VERSION DESCRIPTION
nfd/node-feature-discovery 0.16.5 v0.16.5 Detects hardware features available on each nod...
Thanks alot for your effort and the quick release!
/close in favor of https://github.com/kubernetes-sigs/node-feature-discovery/pull/1909
@tobiasgiese: Closing this issue.
Release Checklist
hack/prepare-release.sh $VERSION
to turn references to point to the upcoming release (README, deployment templates, docs configuration, test/e2e flags), submit a PR against the release branchprepare-release.sh
script above to the draft releasegit tag -s -m "NFD release $VERSION" $VERSION
git push $VERSION
gcr.io/k8s-staging-nfd/node-feature-discovery:$VERSION
registry.k8s.io/images/k8s-staging-nfd/images.yaml
to promote the container images (both "full" and "minimal" variants) to productionregistry.k8s.io/nfd/node-feature-discovery:$VERSION
) is available.hack/prepare-release.sh $VERSION
but only committing README.md, and, submit a PRChangelog
Fixes an nfd-master memory leak on re-configure events when leader election is enabled.