kubernetes-sigs / node-feature-discovery

Node feature discovery for Kubernetes
Apache License 2.0
781 stars 242 forks source link

Release v0.16.5 #1849

Closed marquiz closed 1 week ago

marquiz commented 2 months ago

Release Checklist

Changelog

Fixes an nfd-master memory leak on re-configure events when leader election is enabled.

marquiz commented 2 months ago

At least fix #1841 (#1848)

ArangoGutierrez commented 1 month ago

Maybe also https://github.com/kubernetes-sigs/node-feature-discovery/pull/1878?

marquiz commented 1 month ago

Maybe also #1878?

We could take that. But host networks also requires #1885 which is a bit more controversial for a patch release

tobiasgiese commented 1 month ago

But host networks also requires #1885 which is a bit more controversial for a patch release

From my perspective, this PR doesn’t introduce any changes to the core logic or default behavior, so the impact should be minimal. The Helm value retains a default setting if not explicitly configured. Given that, I believe it should be safe to include in the patch release.

marquiz commented 2 weeks ago

@tobiasgiese fair enough. I agree that #1885 is very low risk, let's cherry-pick

marquiz commented 1 week ago

GitHub release page: https://github.com/kubernetes-sigs/node-feature-discovery/releases/tag/v0.16.5

tobiasgiese commented 1 week ago

Also the helm repo is published

❯ helm search repo nfd
NAME                        CHART VERSION   APP VERSION DESCRIPTION
nfd/node-feature-discovery  0.16.5          v0.16.5     Detects hardware features available on each nod...

Thanks alot for your effort and the quick release!

tobiasgiese commented 1 week ago

/close in favor of https://github.com/kubernetes-sigs/node-feature-discovery/pull/1909

k8s-ci-robot commented 1 week ago

@tobiasgiese: Closing this issue.

In response to [this](https://github.com/kubernetes-sigs/node-feature-discovery/issues/1849#issuecomment-2413386745): >/close >in favor of https://github.com/kubernetes-sigs/node-feature-discovery/pull/1909 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.