kubernetes-sigs / node-feature-discovery

Node feature discovery for Kubernetes
Apache License 2.0
791 stars 245 forks source link

Can not deploy NFD plain manifest via README.md with the usage of kubectl kustomize #1877

Closed jz543fm closed 1 month ago

jz543fm commented 2 months ago

kubectl apply -k https://github.com/kubernetes-sigs/node-feature-discovery/deployment/overlays/default?ref=v0.16.4

no matches found: https://github.com/kubernetes-sigs/node-feature-discovery/deployment/overlays/default?ref=v0.16.4

I prefer plain Yaml

marquiz commented 2 months ago

Hi @jz543fm. What kubectl version are you using? I suspect you have a very old version that doesn't support kustomize

jz543fm commented 1 month ago

Hi @marquiz

$ kubectl version

Client Version: v1.30.2 Kustomize Version: v5.0.4-0.20230601165947-6ce0bf390ce3

marquiz commented 1 month ago

Hmm, really strange. Worksforme. What could be the issue :thinking:

jz543fm commented 1 month ago

What kubectl version are you using? I would prefer, if there could be found plain manifest for future, if it would be possible, kustomize with different versions with many users is not very good option, or maybe in the doc should be mentioned what version of kustomize works

marquiz commented 1 month ago

What kubectl version are you using?

I have v1.30 and v1.31.

I would prefer, if there could be found plain manifest for future, if it would be possible, kustomize with different versions with many users is not very good option, or maybe in the doc should be mentioned what version of kustomize works

This should really be no problem. Kustomize (with the remote refs) has been supported since kubectl v1.21 or so. I think it is reasonable to ask people to use kubectl v1.21 or later.

Could it be network access somehow (http proxy?). What shell are you using?

EDIT: try kubectl apply -k 'https://github.com/kubernetes-sigs/node-feature-discovery/deployment/overlays/default?ref=v0.16.4'

jz543fm commented 1 month ago

The problem was ' ', when I use it, it works...

marquiz commented 1 month ago

@jz543fm so it was zsh?

jz543fm commented 1 month ago

I am using zsh and bash, I can try it tomorrow on bash too

jz543fm commented 1 month ago

Also bash had issue with it, thanks for fix