kubernetes-sigs / node-feature-discovery

Node feature discovery for Kubernetes
Apache License 2.0
792 stars 245 forks source link

Move testdata to root #1921

Closed elezar closed 1 month ago

elezar commented 1 month ago

Go mod automatically ignores the /testdata directory. This change ensures that the rootfs for source/pci tests are not included in the module definition.

This replaces #1919

netlify[bot] commented 1 month ago

Deploy Preview for kubernetes-sigs-nfd ready!

Name Link
Latest commit b6b1335ec152210866bd2af4d20bd3ea958fa0ba
Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/6716970190b2dc0008f4818b
Deploy Preview https://deploy-preview-1921--kubernetes-sigs-nfd.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

marquiz commented 1 month ago

Makes sense :+1: We just need to make the tests pass

ArangoGutierrez commented 1 month ago

PR https://github.com/elezar/node-feature-discovery/pull/1 fixes tests

k8s-ci-robot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArangoGutierrez, elezar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/node-feature-discovery/blob/master/OWNERS)~~ [ArangoGutierrez] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ArangoGutierrez commented 1 month ago

/test pull-node-feature-discovery-build-image-cross-generic

ArangoGutierrez commented 1 month ago

/milestone v0.17

elezar commented 1 month ago

@ArangoGutierrez @marquiz given that this should address issues in importing the API and client packages could this also be backported to the v0.16.x branch?

marquiz commented 1 month ago

/lgtm

k8s-ci-robot commented 1 month ago

LGTM label has been added.

Git tree hash: 81765fb6ceeed92eb80c2c04981bc9ba8dded491