kubernetes-sigs / node-feature-discovery

Node feature discovery for Kubernetes
Apache License 2.0
792 stars 245 forks source link

Add support for master and garbage collector pod topology spread constraints #1955

Open solidDoWant opened 1 week ago

solidDoWant commented 1 week ago

This adds topologySpreadConstraints fields to the master and garbage collector pods via the Helm chart.

linux-foundation-easycla[bot] commented 1 week ago

CLA Not Signed

k8s-ci-robot commented 1 week ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: solidDoWant Once this PR has been reviewed and has the lgtm label, please assign arangogutierrez for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes-sigs/node-feature-discovery/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
k8s-ci-robot commented 1 week ago

Welcome @solidDoWant!

It looks like this is your first PR to kubernetes-sigs/node-feature-discovery 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/node-feature-discovery has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot commented 1 week ago

Hi @solidDoWant. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
netlify[bot] commented 1 week ago

Deploy Preview for kubernetes-sigs-nfd ready!

Name Link
Latest commit 7a7e7bbe84ddd5450e8a6c43ae1950471afd35ec
Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/67328a5b895c960008ea6ea3
Deploy Preview https://deploy-preview-1955--kubernetes-sigs-nfd.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

solidDoWant commented 1 week ago

Hey folks I agree to the terms and conditions in the CLA but I'm not going to provide my full name, email, and physical address to submit a minor 13 line feature to this project.

Do whatever you want with this PR and the code I have submitted in it, but I will not be signing the CLA due to privacy concerns.