Open solidDoWant opened 1 week ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: solidDoWant Once this PR has been reviewed and has the lgtm label, please assign arangogutierrez for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Welcome @solidDoWant!
It looks like this is your first PR to kubernetes-sigs/node-feature-discovery 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You can also check if kubernetes-sigs/node-feature-discovery has its own contribution guidelines.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to Kubernetes. :smiley:
Hi @solidDoWant. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
Name | Link |
---|---|
Latest commit | 7a7e7bbe84ddd5450e8a6c43ae1950471afd35ec |
Latest deploy log | https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/67328a5b895c960008ea6ea3 |
Deploy Preview | https://deploy-preview-1955--kubernetes-sigs-nfd.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Hey folks I agree to the terms and conditions in the CLA but I'm not going to provide my full name, email, and physical address to submit a minor 13 line feature to this project.
Do whatever you want with this PR and the code I have submitted in it, but I will not be signing the CLA due to privacy concerns.
This adds
topologySpreadConstraints
fields to the master and garbage collector pods via the Helm chart.