search

kubernetes-sigs / node-ipam-controller

Out of tree implementation of https://github.com/kubernetes/enhancements/tree/master/keps/sig-network/2593-multiple-cluster-cidrs
Apache License 2.0
10 stars 11 forks source link

Investigate use of health checks adapter in LeaderElection #26

Open ugur99 opened 3 months ago

ugur99 commented 3 months ago

LeaderElection has an option to specify a health checks adapter. We may need to consider investigating whether this adapter can be useful.

See: #20

Peac36 commented 3 months ago

/assign

Peac36 commented 2 months ago

Hey @mneverov - I did some research on the leader elector health checker. It was introduced as a workaround of the following issue - https://github.com/kubernetes/kubernetes/issues/70819 The issue stems from golang.org/x/net/ library that had a deadlock. To mitigate the issue the health checker was introduced so the deadlock could be detected.

However, the real fix of the issue was introduced with golang 1.11 where the deadlock was removed - https://github.com/golang/net/commit/6a8eb5e2b1816b30aa88d7e3ecf9eb7c4559d9e6

Since we are already on the golang 1.20 I don't reason to implement this.