Updates deploy/manifest to latest version in sync with kube-prom

[JoaoBraveCoding]

Issue https://github.com/kubernetes-sigs/prometheus-adapter/issues/426

[k8s-ci-robot]

Welcome @JoaoBraveCoding!

It looks like this is your first PR to kubernetes-sigs/prometheus-adapter 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/prometheus-adapter has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

[k8s-ci-robot]

Hi @JoaoBraveCoding. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

[JoaoBraveCoding]

@dgrisonnet while upgrading de Walkthrough, I modified the version of the HPA created to v2beta2 since v2beta1 is unavailable on 1.25+. However, in v2beta2 if we configure the HPA to scale on pod metrics then it will look for pod metrics under the API pod.custom.metrics.k8s.io while v2beta1 looks for them under custom.metrics.k8s.io. Does this mean that in 1.25+ if we want to HPA with custom metrics using the adapter then we will have to register an APIService that will service metrics under pod.custom.metrics.k8s.io instead of the usual custom.metrics.k8s.io, is this the correct way of doing things or am I missing something?

[JoaoBraveCoding]

@dgrisonnet while upgrading de Walkthrough, I modified the version of the HPA created to v2beta2 since v2beta1 is unavailable on 1.25+. However, in v2beta2 if we configure the HPA to scale on pod metrics then it will look for pod metrics under the API pod.custom.metrics.k8s.io while v2beta1 looks for them under custom.metrics.k8s.io. Does this mean that in 1.25+ if we want to HPA with custom metrics using the adapter then we will have to register an APIService that will service metrics under pod.custom.metrics.k8s.io instead of the usual custom.metrics.k8s.io, is this the correct way of doing things or am I missing something?

I think I got it working, will submit an update to the PR soon

[JoaoBraveCoding]

Also, something we could consider doing in the future would be to set up a simple CI job that would check that the manifests are getting applied in a cluster properly and that prometheus-adapter is running. Ideally, we should do that during the e2e tests but since we don't have any, just a simple check verifying that the pod is running would be a great start.

100% agree, I could also help with that but I would prefer to do it in a follow-up PR if it's OK, if you want I can create an issue for it.

In the future, we could make the different setup configurable via jsonnet, but for now, let's just stick to the default use-case.

Also agree that this would be nice, I'm happy to also help with it in a followup

[dgrisonnet]

Great work, thanks @JoaoBraveCoding!

/lgtm /approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgrisonnet, JoaoBraveCoding, olivierlemasle

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/prometheus-adapter/blob/master/OWNERS)~~ [dgrisonnet] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment