search

kubernetes-sigs / prometheus-adapter

An implementation of the custom.metrics.k8s.io API using Prometheus
Apache License 2.0
1.9k stars 551 forks source link

Update prometheus-adapter go patch versions #616

Closed jaybooth4 closed 10 months ago

jaybooth4 commented 10 months ago 
Upgrade to 1.20.10 to address multiple CVE security findings
k8s-ci-robot commented 10 months ago

Hi @jaybooth4. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
dashpole commented 10 months ago

/assign @dgrisonnet /triage accpeted

k8s-ci-robot commented 10 months ago

@dashpole: The label(s) triage/accpeted cannot be applied, because the repository doesn't have them.

In response to [this](https://github.com/kubernetes-sigs/prometheus-adapter/pull/616#issuecomment-1787318243): >/assign @dgrisonnet >/triage accpeted Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
jaybooth4 commented 10 months ago

I think this should be /triage accepted instead of /triage accpeted (typo)

dashpole commented 10 months ago

/triage accepted

dongjiang1989 commented 10 months ago

/assign @dgrisonnet

logicalhan commented 10 months ago

/ok-to-test

dgrisonnet commented 10 months ago

/lgtm /approve

k8s-ci-robot commented 10 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgrisonnet, jaybooth4

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/prometheus-adapter/blob/release-0.11/OWNERS)~~ [dgrisonnet] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
jaybooth4 commented 10 months ago

Thanks @dgrisonnet ! Would you be able to review https://github.com/kubernetes-sigs/prometheus-adapter/pull/617 as well to cut a new release?

jaybooth4 commented 10 months ago

Also created https://github.com/kubernetes-sigs/prometheus-adapter/pull/620 to update master