Instrument metrics - Githubissues

kubernetes-sigs / prometheus-adapter

An implementation of the custom.metrics.k8s.io API using Prometheus

Apache License 2.0

1.9k stars 551 forks source link

Instrument metrics #645

Open cerberus20 opened 6 months ago

cerberus20 commented 6 months ago

linux-foundation-easycla[bot] commented 6 months ago

The committers listed above are authorized under a signed CLA.

:white_check_mark: login: cerberus20 (2ba4422ea4a960d7e6ff7509aeb57999e75c54fc, 57b07c911bf44489c41792b5b95ebf64ed216094, b01d7ac59d68f72694d9f1e8f4eac040e108d08c, 118b2fe0495b5f51eb1c2df3baf1d0ee59a9533e, e70cb4278073eb30d4ee25f02bc416af49bd6271, abe484a7b6188a7a4b304aa2bb503cb5a3a60264, 34c2e3ebd31ab4abdb458a226cf4e217e21f92f1, 28cd9fdb0966aa098e7c3553a3b9fc04235d7ba8, 00c093074c7cc80e942e18158d44920976421dfb, 489349152a0f6f07f933df07f2ced3356563e857, fdff124fb1afd2b415602efd16b8d78f2776b220, 8480eefde57bea69ceff2d912ad45ba9de6622fa)

k8s-ci-robot commented 6 months ago

Hi @cerberus20. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

dashpole commented 6 months ago

/assign @dgrisonnet /triage accepted

k8s-ci-robot commented 5 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cerberus20 Once this PR has been reviewed and has the lgtm label, please ask for approval from dgrisonnet. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes-sigs/prometheus-adapter/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

cerberus20 commented 5 months ago

@dgrisonnet /ping

cerberus20 commented 4 months ago

@dgrisonnet Can you please help review? thank you.