kubernetes-sigs / prometheus-adapter

An implementation of the custom.metrics.k8s.io API using Prometheus
Apache License 2.0
1.9k stars 551 forks source link

WIP - Generate sbom on release #646

Closed ricardoapl closed 5 months ago

ricardoapl commented 6 months ago

Generate an SBOM for each new release of prometheus-adapter

Part of https://github.com/kubernetes-sigs/prometheus-adapter/issues/638

k8s-ci-robot commented 6 months ago

Welcome @ricardoapl!

It looks like this is your first PR to kubernetes-sigs/prometheus-adapter 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/prometheus-adapter has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot commented 6 months ago

Hi @ricardoapl. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
k8s-ci-robot commented 6 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ricardoapl Once this PR has been reviewed and has the lgtm label, please assign dgrisonnet for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes-sigs/prometheus-adapter/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ricardoapl commented 6 months ago

It's not clear to me how we should go about signing SBOMs. KEP-3031: Signing release artifacts doesn't seem to apply outside of k/k, and there's also an open discussion at https://github.com/kubernetes/release/issues/2286. I suggest we tackle signing SBOMs in a separate pull request.

What do you think?

dashpole commented 6 months ago

/triage accepted /assign @dgrisonnet

ricardoapl commented 6 months ago

Maybe not worth pursuing this given that prometheus-adapter will be archived?

ricardoapl commented 5 months ago

/close

This is not relevant anymore as discussed in https://github.com/kubernetes-sigs/prometheus-adapter/issues/638

k8s-ci-robot commented 5 months ago

@ricardoapl: Closed this PR.

In response to [this](https://github.com/kubernetes-sigs/prometheus-adapter/pull/646#issuecomment-2031997906): >/close > >This is not relevant anymore as discussed in https://github.com/kubernetes-sigs/prometheus-adapter/issues/638 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.