Closed machine424 closed 5 months ago
This issue is currently awaiting triage.
If prometheus-adapter contributors determine this is a relevant issue, they will accept it by applying the triage/accepted
label and provide further guidance.
The triage/accepted
label can be added by org members by writing /triage accepted
in a comment.
Hi @machine424. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
@dgrisonnet I'd like to get this merged (upstream) before merging the equivalent downstream.
/lgtm /approve
/retest-required
@juzhao: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test
message.
/retest
@machine424: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test
message.
I had to update some more otel deps to fix some conflicts. The tests/checks are happier on my go1.20 env now.
/ok-to-test
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: dgrisonnet, machine424
The full list of commands accepted by this bot can be found here.
The pull request process is described here
…bilty, see https://github.com/golang/protobuf/issues/1596#issuecomment-1981208282
upgrade go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp to v0.49.0 to address CVE-2023-45142 even though prometheus-adapter isn't using it directly and isn't exposing any traces.
This supersedes https://github.com/kubernetes-sigs/prometheus-adapter/pull/648