kubernetes-sigs / prometheus-adapter

An implementation of the custom.metrics.k8s.io API using Prometheus
Apache License 2.0
1.9k stars 551 forks source link

Cut release 0.11.3 #658

Closed jaybooth4 closed 3 months ago

jaybooth4 commented 4 months ago

Getting release changes ready to make it easy to cut a new version 👍

k8s-ci-robot commented 4 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jaybooth4 Once this PR has been reviewed and has the lgtm label, please assign dgrisonnet for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes-sigs/prometheus-adapter/blob/release-0.11/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
k8s-ci-robot commented 4 months ago

Hi @jaybooth4. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
logicalhan commented 4 months ago

/triage accepted /assign @logicalhan

logicalhan commented 4 months ago

/assign @dgrisonnet

dgrisonnet commented 4 months ago

@jaybooth4 do you specifically need a patch version?

I was considering cutting 0.12.0 based on Kubernetes 1.30 since Kubernetes 1.27 that 0.11 is based on is not supported anymore.

I can cut it tomorrow as long as https://github.com/kubernetes-sigs/custom-metrics-apiserver/pull/172 goes in

jaybooth4 commented 4 months ago

Hey @dgrisonnet, no that sounds good! Let me know if you'd like any CLs around cutting a new release 👍

chc5 commented 3 months ago

Are there any updates here?

@dgrisonnet Since https://github.com/kubernetes-sigs/custom-metrics-apiserver/pull/172 was merged, do you want to review the following change here?

dgrisonnet commented 3 months ago

Superseded by https://github.com/kubernetes-sigs/prometheus-adapter/pull/659.

I'll work on the 0.12.0 release now.