kubernetes-sigs / prometheus-adapter

An implementation of the custom.metrics.k8s.io API using Prometheus
Apache License 2.0
1.9k stars 551 forks source link

Bump to Kubernetes 1.30 #659

Closed dgrisonnet closed 3 months ago

dgrisonnet commented 4 months ago

Bump all the dependencies, custom-metrics-apiserver and Kubenetes to 1.30.

Since there is no kind image available for 1.30 yet, I built one myself and use it in the tests. I will change that later once an official image is available.

k8s-ci-robot commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgrisonnet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/prometheus-adapter/blob/master/OWNERS)~~ [dgrisonnet] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
dgrisonnet commented 4 months ago

cc @jaybooth4

CatherineF-dev commented 4 months ago

Regarding version skew, could users deploy prometheus-adapter 1.30 in cluster k8s 1.28?

dgrisonnet commented 4 months ago

They should be able to do that, I don't recall any breaking change that would cause it not to work on 1.28.

Maybe if you have some bandwidth, it could be worth improving the tests by testing across multiple Kubernetes versions like we do in metrics-server.

dgrisonnet commented 4 months ago

/retest-required

dgrisonnet commented 4 months ago

/retest-required

dgrisonnet commented 4 months ago

/retest-required

dgrisonnet commented 4 months ago

There is an odd issue with the linter, I'll investigate. I'll look at the e2e tests later

chc5 commented 3 months ago

Any updates here? I'd like to get these upgrades submitted to address vulnerabilities in this project.

dgrisonnet commented 3 months ago

If you are talking about the otel CVE, the project is not affected. That said, I'll be looking at this PR again soon.

dgrisonnet commented 3 months ago

/assign @CatherineF-dev /triage accepted

CatherineF-dev commented 3 months ago

/lgtm