Closed dgrisonnet closed 3 months ago
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: dgrisonnet
The full list of commands accepted by this bot can be found here.
The pull request process is described here
cc @jaybooth4
Regarding version skew, could users deploy prometheus-adapter 1.30 in cluster k8s 1.28?
They should be able to do that, I don't recall any breaking change that would cause it not to work on 1.28.
Maybe if you have some bandwidth, it could be worth improving the tests by testing across multiple Kubernetes versions like we do in metrics-server.
/retest-required
/retest-required
/retest-required
There is an odd issue with the linter, I'll investigate. I'll look at the e2e tests later
Any updates here? I'd like to get these upgrades submitted to address vulnerabilities in this project.
If you are talking about the otel CVE, the project is not affected. That said, I'll be looking at this PR again soon.
/assign @CatherineF-dev /triage accepted
/lgtm
Bump all the dependencies, custom-metrics-apiserver and Kubenetes to 1.30.
Since there is no kind image available for 1.30 yet, I built one myself and use it in the tests. I will change that later once an official image is available.