cpanato
commented
11 months ago I think we never thought of running that on windows, but we can fix that for sure
are you willing to work on this to fix the issue?
Open H0llyW00dzZ opened 11 months ago
cpanato
commented
11 months ago I think we never thought of running that on windows, but we can fix that for sure
are you willing to work on this to fix the issue?
H0llyW00dzZ
commented
11 months ago I think we never thought of running that on windows, but we can fix that for sure
well, was trying to install on windows
are you willing to work on this to fix the issue?
I can try by using this method
var (
// ExitSignals are used to determine if an incoming os.Signal should cause termination.
ExitSignals = map[os.Signal]bool{
syscall.SIGHUP: true,
syscall.SIGINT: true,
syscall.SIGABRT: true,
syscall.SIGILL: true,
syscall.SIGQUIT: true,
syscall.SIGTERM: true,
syscall.SIGSEGV: true,
// syscall.SIGTSTP is conditionally added in init() not a global variable
}
// ExitChannel is for gracefully terminating the LogSignals() function.
ExitChannel = make(chan bool, 1)
// SignalChannel is for listening to OS signals.
SignalChannel = make(chan os.Signal, 1)
// Debug is defined globally for mocking logrus.Debug statements.
Debug func(args ...interface{}) = logrus.Debug
)
func init() {
// Only include SIGTSTP if not on Windows
if runtime.GOOS != "windows" {
ExitSignals[syscall.SIGTSTP] = true
}
}By adding this init() function, the syscall.SIGTSTP signal will only be added to the ExitSignals map if the program is not running on Windows. This ensures that the code is portable and will compile successfully on all platforms supported by Go.
Edit :
fixes now
k8s-triage-robot
commented
8 months ago The Kubernetes project currently lacks enough contributors to adequately respond to all issues.
This bot triages un-triaged issues according to the following rules:
lifecycle/stale is appliedlifecycle/stale was applied, lifecycle/rotten is appliedlifecycle/rotten was applied, the issue is closedYou can:
/remove-lifecycle stale/closePlease send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale
xmudrii
commented
7 months ago /remove-lifecycle stale
k8s-triage-robot
commented
4 months ago The Kubernetes project currently lacks enough contributors to adequately respond to all issues.
This bot triages un-triaged issues according to the following rules:
lifecycle/stale is appliedlifecycle/stale was applied, lifecycle/rotten is appliedlifecycle/rotten was applied, the issue is closedYou can:
/remove-lifecycle stale/closePlease send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale
k8s-triage-robot
commented
3 months ago The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.
This bot triages un-triaged issues according to the following rules:
lifecycle/stale is appliedlifecycle/stale was applied, lifecycle/rotten is appliedlifecycle/rotten was applied, the issue is closedYou can:
/remove-lifecycle rotten/closePlease send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle rotten
xmudrii
commented
3 months ago /remove-lifecycle rotten
k8s-triage-robot
commented
5 days ago The Kubernetes project currently lacks enough contributors to adequately respond to all issues.
This bot triages un-triaged issues according to the following rules:
lifecycle/stale is appliedlifecycle/stale was applied, lifecycle/rotten is appliedlifecycle/rotten was applied, the issue is closedYou can:
/remove-lifecycle stale/closePlease send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale
xmudrii
commented
3 days ago /remove-lifecycle stale
What happened:
There was a problem when installing the latest version of the software And got response:
What you expected to happen:
syscall.SIGTSTPis not available on Windows.How to reproduce it (as minimally and precisely as possible):
run this
Anything else we need to know?:
Windows does not use signals in the same way as Unix-like systems
Environment:
Windows 11