search

kubernetes-sigs / prow

Prow is a Kubernetes based CI/CD system developed to serve the Kubernetes community. This repository contains Prow source code and Hugo sources for Prow documentation site.
https://docs.prow.k8s.io
Apache License 2.0
130 stars 99 forks source link

Revert "Revert "`gangway`: add status change endpoint"" #158

Closed Prucek closed 6 months ago

Prucek commented 6 months ago

Reverts kubernetes-sigs/prow#156

k8s-ci-robot commented 6 months ago

Hi @Prucek. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
netlify[bot] commented 6 months ago

Deploy Preview for k8s-prow ready!

Name Link
Latest commit bca239a039f04dc0fe2003673633238bad70835b
Latest deploy log https://app.netlify.com/sites/k8s-prow/deploys/664c92aee8dc75000898923e
Deploy Preview https://deploy-preview-158--k8s-prow.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

petr-muller commented 6 months ago

/ok-to-test

petr-muller commented 6 months ago

FYI these are the failures we saw (and why I reverted the PR):

https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_prow/155/pull-prow-integration/1791473589053034496 https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_prow/155/pull-prow-integration/1791466104812474368

Prucek commented 6 months ago

2024-05-17T13:58:28.169262008Z stderr F {"branch":"master","component":"gangway","error":"got 400 response","file":"sigs.k8s.io/prow/pkg/gangway/gangway.go:935","func":"sigs.k8s.io/prow/pkg/gangway.(*postsubmitJobHandler).getProwJobSpec","level":"info","msg":"Failed to get postsubmits from inrepoconfig","org":"org1","orgRepo":"org1/repo1","repo":"repo1","severity":"info","time":"2024-05-17T13:58:28Z"} I have been looking at the gangway logs in the integration test, and I see the error comes from postsubmits I guess But it is hard to look for the error because locally it didn't occur to me not even once

linux-foundation-easycla[bot] commented 6 months ago

CLA Missing ID CLA Not Signed

k8s-ci-robot commented 6 months ago

PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
k8s-ci-robot commented 6 months ago

@Prucek: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-prow-image-build-test d07157db1b12ef19c40e0856caacae8bef922644 link true /test pull-prow-image-build-test
pull-prow-integration d07157db1b12ef19c40e0856caacae8bef922644 link true /test pull-prow-integration

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
k8s-ci-robot commented 6 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Prucek

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
Prucek commented 6 months ago

I didn't close it, it closed on its own

petr-muller commented 5 months ago

@Prucek That's a fun little GitHub quirk. You have force pushed the bca239a commit to be the tip of this PR:

Prucek force-pushed the revert-156-revert-116-mass-job-status-change-api branch from d07157d to bca239a

Now, bca239a is the commit that was merged as a tip of the original (reverted) PR #116: https://github.com/kubernetes-sigs/prow/pull/116/commits

Which means this PR #158 would be a duplicate of an already closed PR #116 and therefore GitHub closes it too (normally this can happen when you have two open PRs trying to merge identical set of commits - once one of them merges, GitHub closes the other as well).

Prucek commented 5 months ago

@petr-muller thanks for the explanation, now it makes sense