kubernetes-sigs / prow

Prow is a Kubernetes based CI/CD system developed to serve the Kubernetes community. This repository contains Prow source code and Hugo sources for Prow documentation site.
https://docs.prow.k8s.io
Apache License 2.0
127 stars 98 forks source link

Revert "Revert "`gangway`: add status change endpoint"" #159

Closed Prucek closed 5 months ago

Prucek commented 6 months ago

Original PR: https://github.com/kubernetes-sigs/prow/pull/116 Reverts kubernetes-sigs/prow#156 Resolves: kubernetes-sigs/prow#155

The problem was in the WaitForJobExecutionStatus() method, it was only waiting for the execution to exist and not for the actual status to appear, and then of course, sometimes it was pending and sometimes triggered, and that caused the flakiness. A simple true->false solved it.

k8s-ci-robot commented 6 months ago

Hi @Prucek. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
netlify[bot] commented 6 months ago

Deploy Preview for k8s-prow ready!

Name Link
Latest commit 4052cd03048ded27ef122d1a9e7a145fed483d48
Latest deploy log https://app.netlify.com/sites/k8s-prow/deploys/6659ab46bbfcf300084031c7
Deploy Preview https://deploy-preview-159--k8s-prow.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

danilo-gemoli commented 5 months ago

/ok-to-test

Prucek commented 5 months ago

/test pull-prow-integration

Prucek commented 5 months ago

/hold

Prucek commented 5 months ago

/test pull-prow-integration /unhold

petr-muller commented 5 months ago

Can you drop a sentence or two into the description about what the problem was and what is the fix?

smg247 commented 5 months ago

/test pull-prow-integration

let's try it once more ;)

petr-muller commented 5 months ago

/test integration /approve

@smg247 seeing you already reviewed the code I'm leaving the lgtm up to you ;)

k8s-ci-robot commented 5 months ago

@petr-muller: The specified target(s) for /test were not found. The following commands are available to trigger required jobs:

The following commands are available to trigger optional jobs:

Use /test all to run all jobs.

In response to [this](https://github.com/kubernetes-sigs/prow/pull/159#issuecomment-2141940778): >/test integration >/approve > >@smg247 seeing you already reviewed the code I'm leaving the lgtm up to you ;) Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
k8s-ci-robot commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: petr-muller, Prucek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/prow/blob/main/OWNERS)~~ [petr-muller] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
petr-muller commented 5 months ago

/test pull-prow-integration

smg247 commented 5 months ago

/lgtm