Closed Prucek closed 5 months ago
Hi @Prucek. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
Name | Link |
---|---|
Latest commit | 4052cd03048ded27ef122d1a9e7a145fed483d48 |
Latest deploy log | https://app.netlify.com/sites/k8s-prow/deploys/6659ab46bbfcf300084031c7 |
Deploy Preview | https://deploy-preview-159--k8s-prow.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
/ok-to-test
/test pull-prow-integration
/hold
/test pull-prow-integration /unhold
Can you drop a sentence or two into the description about what the problem was and what is the fix?
/test pull-prow-integration
let's try it once more ;)
/test integration /approve
@smg247 seeing you already reviewed the code I'm leaving the lgtm up to you ;)
@petr-muller: The specified target(s) for /test
were not found.
The following commands are available to trigger required jobs:
/test pull-prow-image-build-test
/test pull-prow-integration
/test pull-prow-unit-test
/test pull-prow-verify-lint
The following commands are available to trigger optional jobs:
/test pull-prow-unit-test-race-detector-nonblocking
Use /test all
to run all jobs.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: petr-muller, Prucek
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/test pull-prow-integration
/lgtm
Original PR: https://github.com/kubernetes-sigs/prow/pull/116 Reverts kubernetes-sigs/prow#156 Resolves: kubernetes-sigs/prow#155
The problem was in the
WaitForJobExecutionStatus()
method, it was only waiting for the execution to exist and not for the actual status to appear, and then of course, sometimes it waspending
and sometimestriggered
, and that caused the flakiness. A simple true->false solved it.